Skip to content

Transpile JS to ES5 before building #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cigolpl merged 3 commits into from
Sep 4, 2018
Merged

Transpile JS to ES5 before building #22

cigolpl merged 3 commits into from
Sep 4, 2018

Conversation

@saminzadeh
Copy link
Contributor

@saminzadeh saminzadeh commented Sep 4, 2018

As discussed in this PR:

  • Adds babel to the project to convert ES6 to ES5, outputs to lib/ which should be built before publishing to NPM
  • Moves to lodash to vendor folder
  • Build project with npm run build

@saminzadeh saminzadeh mentioned this pull request Sep 4, 2018
Closed
@cigolpl
Copy link
Member

cigolpl commented Sep 4, 2018

Build works great! Passing all tests. Thanks for PR. I'll merge it to master, increase version in package and publish to npm (if that makes sense)

@cigolpl cigolpl merged commit 72737fc into itemsapi:development Sep 4, 2018
@cigolpl cigolpl mentioned this pull request Sep 4, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@saminzadeh @cigolpl