Skip to content

Conversation

@hiqua
Copy link
Collaborator

@hiqua hiqua commented Apr 14, 2022

Fixes #1131.

@hiqua hiqua requested a review from iSoron April 14, 2022 20:23
@iSoron
Copy link
Owner

iSoron commented Apr 15, 2022

Thanks, @hiqua. Would you like to write a regression UI test for this bug. We already have some in ListHabitsRegressionTest.

@hiqua
Copy link
Collaborator Author

hiqua commented Apr 16, 2022

Done, added the commit before to make it easier to check it does fail without the check, please squash them before merging (to avoid a failing commit on dev).

Edit: it's a shame that the tests don't run automatically on every commit in each PR, couldn't find a quick way to do that, but you can check manually that the test fails with just the first commit and passes with the second one.

@iSoron iSoron merged commit c453810 into iSoron:dev Apr 21, 2022
@iSoron
Copy link
Owner

iSoron commented Apr 21, 2022

Thanks, @hiqua!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Changing habit goals should trigger a sort refresh

2 participants