Fix/1924 by conradmugabe · Pull Request #253 · iblai/os

conradmugabe · 2026-06-12T18:46:57Z

Checklist

Tests were added/updated according to the feature/bugfix/change made
Version was rolled according to semver requirements
API endpoints openapi schema was updated if applicable

Changes

Closes https://github.com/iblai/iblai-platform/issues/1924
Add RBAC permissions to the datasets tab 'add resource button'

…sion Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

mamigot · 2026-06-12T18:47:18Z

Claude finished @conradmugabe's task —— View job

E2E Coverage Bot Analysis ✅

Reviewing PR #253 for e2e test coverage requirements.

Todo List:

Step 1: Dismiss stale REQUEST_CHANGES reviews from myself (no existing reviews found)
Step 2: Identify what changed (check for new page.tsx files)
Step 3: Run mechanical coverage check
Step 4: Read current coverage state
Step 5: Apply decision logic and post GitHub review

Analysis:

Changed files:

components/modals/edit-mentor-modal/tabs/datasets-tab/index.test.tsx (test file)
components/modals/edit-mentor-modal/tabs/datasets-tab/index.tsx (component file)
pnpm-lock.yaml (dependency lock file)

Key Finding: No new app/**/page.tsx files were added - this PR only modifies existing components within a modal tab.

Coverage Check Result: ❌ FAILED

Checkpoints decreased from 442 to 434 (−8)
Journey count decreased from 51 to 50

Decision: CASE D - Mechanical check FAILED (checkpoint regression)

Action Taken: Posted REQUEST_CHANGES review explaining that checkpoint count regression is not allowed and requesting the removed checkpoints be restored or justified.

mamigot

❌ E2E Checkpoint Regression

The checkpoint count in `e2e/coverage.json` decreased compared to `origin/main`.
Removing or reducing test coverage is not allowed.

Coverage check output:
```
Coverage REGRESSION: checkpoints decreased from 442 to 434 (−8)
You must not remove checkpoints without replacing them. Add tests for removed functionality or restore the checkpoints.
Journey REGRESSION: journey count decreased from 51 to 50
Journey coverage: 24/24 files mapped (100%)
Coverage check failed: new routes need E2E journey coverage.
```

To fix: restore the removed checkpoints or justify the removal by updating COVERAGE.md with a note.

mamigot · 2026-06-15T20:47:59Z

Claude encountered an error —— View job

I'll analyze this and get back to you.

mamigot · 2026-06-16T13:54:00Z

Claude encountered an error —— View job

I'll analyze this and get back to you.

mamigot · 2026-06-17T14:45:18Z

Claude finished @conradmugabe's task —— View job

E2E Coverage Bot Analysis ✅

Todo List:

Step 1: Dismiss stale REQUEST_CHANGES reviews from myself
Step 2: Identify what changed (check for new page.tsx files)
Step 3: Run mechanical coverage check
Step 4: Read current coverage state
Step 5: Apply decision logic and post GitHub review

Analysis:

Changed files:

components/modals/edit-mentor-modal/tabs/datasets-tab/index.test.tsx (test file)
components/modals/edit-mentor-modal/tabs/datasets-tab/index.tsx (component file)
pnpm-lock.yaml (dependency lock file)

Key Finding: No new app/**/page.tsx files were added.

Coverage Check Result: ✅ PASSED

Coverage unchanged: 443 checkpoints
Journey coverage: 24/24 files mapped (100%)

Decision: CASE E — No new app routes, mechanical check passed → Approved ✅

Re-evaluating after new commits.

mamigot

✅ E2E Coverage — No Issues

No new app routes were introduced. All existing coverage is intact.

Coverage check output:

Coverage unchanged: 443 checkpoints
Journey coverage: 24/24 files mapped (100%)

mamigot · 2026-06-17T16:31:55Z

Claude finished @conradmugabe's task —— View job

E2E Coverage Bot Analysis ✅

Todo List:

Step 1: Dismiss stale REQUEST_CHANGES reviews from myself (no existing reviews found)
Step 2: Identify what changed (check for new page.tsx files)
Step 3: Run mechanical coverage check
Step 4: Read current coverage state
Step 5: Apply decision logic and post GitHub review

Analysis:

Changed files:

components/modals/edit-mentor-modal/tabs/datasets-tab/index.test.tsx (test file)
components/modals/edit-mentor-modal/tabs/datasets-tab/index.tsx (component file)
pnpm-lock.yaml (dependency lock file)

Key Finding: No new app/**/page.tsx files were added - this PR only modifies existing components within a modal tab.

Coverage Check Result: ✅ PASSED

Coverage unchanged: 443 checkpoints
Journey coverage: 24/24 files mapped (100%)

Decision: CASE E — No new app routes, mechanical check passed → Approved ✅

mamigot

✅ E2E Coverage — No Issues

No new app routes were introduced. All existing coverage is intact.

Coverage check output:

Coverage unchanged: 443 checkpoints
Journey coverage: 24/24 files mapped (100%)

…rcepted EditMentorModal was rendered by multiple always-mounted parents (nav-bar and settings-modal) gated on the same global showEditMentorModal flag. Opening Edit from the My Agents list mounted two stacked Edit Agent dialogs; the backgrounded copy was covered by the duplicate, leaving the Close button unclickable and dropping the dialog from the a11y tree. Render one EditMentorModal in ModalContainer, after SettingsModal, so it is the top, interactive layer, and remove the redundant instances from nav-bar and settings-modal. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

…roup The Analytics sidebar entry is now a collapsible group: clicking its header only toggles the submenu, so the anonymous auth-gate assertion never fired and the test failed. Expand Analytics, click the Overview leaf (which routes an anonymous user to the auth host via runAdminAction -> redirectToLogin), and assert the redirect. Also drops the vacuous isVisible guard since anonymous users are meant to see the Analytics section. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

mamigot · 2026-06-18T03:04:47Z

Claude finished @conradmugabe's task —— View job

E2E Coverage Bot Analysis ✅

Todo List:

Step 1: Dismiss stale REQUEST_CHANGES reviews from myself (no existing reviews found)
Step 2: Identify what changed (check for new page.tsx files)
Step 3: Run mechanical coverage check
Step 4: Read current coverage state
Step 5: Apply decision logic and post GitHub review

Analysis:

Changed files:

components/modals/edit-mentor-modal/tabs/datasets-tab/index.test.tsx (test file)
components/modals/edit-mentor-modal/tabs/datasets-tab/index.tsx (component file)
components/modals/modal-container.tsx (component file)
components/modals/settings-modal.tsx (component file)
app/platform/[tenantKey]/[mentorId]/_components/nav-bar/index.tsx (component file)
e2e/journeys/14-anonymous-public-access.spec.ts (e2e spec update)
pnpm-lock.yaml (dependency lock file)

Key Finding: No new app/**/page.tsx files were added - this PR only modifies existing components within a modal tab.

Coverage Check Result: ✅ PASSED

Coverage unchanged: 443 checkpoints
Journey coverage: 24/24 files mapped (100%)

Decision: CASE E — No new app routes, mechanical check passed → Approved ✅

mamigot

✅ E2E Coverage — No Issues

No new app routes were introduced. All existing coverage is intact.

Coverage check output:

Coverage unchanged: 443 checkpoints
Journey coverage: 24/24 files mapped (100%)

Fix/1924

conradmugabe and others added 2 commits June 12, 2026 21:25

fix(mentor): hide Add Resource button without documents create permis…

8a8f259

…sion Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

test(mentor): cover RBAC gating of Add Resource button

235c322

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

conradmugabe requested a review from mamigot as a code owner June 12, 2026 18:46

conradmugabe self-assigned this Jun 12, 2026

conradmugabe added the run-tests Trigger PR validation pipeline label Jun 12, 2026

conradmugabe requested a review from sonegillis1 June 12, 2026 18:47

mamigot previously requested changes Jun 12, 2026

View reviewed changes

Merge branch 'main' into fix/1924

f529695

conradmugabe requested a review from mamigot June 15, 2026 20:47

Merge branch 'main' into fix/1924

7685b70

Merge branch 'main' into fix/1924

f9842e0

mamigot approved these changes Jun 17, 2026

View reviewed changes

bnsoni mentioned this pull request Jun 17, 2026

fix: repair dangling CLAUDE.md symlink (stray newline broke SPA build) #267

Merged

conradmugabe added run-tests Trigger PR validation pipeline and removed run-tests Trigger PR validation pipeline labels Jun 17, 2026

Merge branch 'main' into fix/1924

ff7ac1f

conradmugabe added the run-tests Trigger PR validation pipeline label Jun 17, 2026

mamigot approved these changes Jun 17, 2026

View reviewed changes

conradmugabe and others added 2 commits June 18, 2026 05:30

mamigot approved these changes Jun 18, 2026

View reviewed changes

conradmugabe requested a review from michael-on-code June 18, 2026 12:11

michael-on-code approved these changes Jun 18, 2026

View reviewed changes

michael-on-code merged commit 6a93d8a into main Jun 18, 2026
10 checks passed

michael-on-code added a commit that referenced this pull request Jun 30, 2026

Merge pull request #253 from iblai/fix/1924

b4ce428

Fix/1924

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix/1924#253

Fix/1924#253
michael-on-code merged 8 commits into
mainfrom
fix/1924

conradmugabe commented Jun 12, 2026

Uh oh!

mamigot commented Jun 12, 2026 •

edited

Loading

Uh oh!

mamigot left a comment

Uh oh!

mamigot commented Jun 15, 2026 •

edited

Loading

Uh oh!

mamigot commented Jun 16, 2026 •

edited

Loading

Uh oh!

mamigot commented Jun 17, 2026 •

edited

Loading

Uh oh!

mamigot left a comment

Uh oh!

mamigot commented Jun 17, 2026 •

edited

Loading

Uh oh!

mamigot left a comment

Uh oh!

mamigot commented Jun 18, 2026 •

edited

Loading

Uh oh!

mamigot left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

conradmugabe commented Jun 12, 2026

Checklist

Changes

Uh oh!

mamigot commented Jun 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

E2E Coverage Bot Analysis ✅

Todo List:

Analysis:

Uh oh!

mamigot left a comment

Choose a reason for hiding this comment

❌ E2E Checkpoint Regression

Uh oh!

mamigot commented Jun 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mamigot commented Jun 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mamigot commented Jun 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

E2E Coverage Bot Analysis ✅

Todo List:

Analysis:

Uh oh!

mamigot left a comment

Choose a reason for hiding this comment

✅ E2E Coverage — No Issues

Uh oh!

mamigot commented Jun 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

E2E Coverage Bot Analysis ✅

Todo List:

Analysis:

Uh oh!

mamigot left a comment

Choose a reason for hiding this comment

✅ E2E Coverage — No Issues

Uh oh!

mamigot commented Jun 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

E2E Coverage Bot Analysis ✅

Todo List:

Analysis:

Uh oh!

mamigot left a comment

Choose a reason for hiding this comment

✅ E2E Coverage — No Issues

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mamigot commented Jun 12, 2026 •

edited

Loading

mamigot commented Jun 15, 2026 •

edited

Loading

mamigot commented Jun 16, 2026 •

edited

Loading

mamigot commented Jun 17, 2026 •

edited

Loading

mamigot commented Jun 17, 2026 •

edited

Loading

mamigot commented Jun 18, 2026 •

edited

Loading