Fix Swift Package Build#2
Merged
Merged
Conversation
Fix Swift Package build which pulls libgit2 1.9.1 instead of libgit2 …
Owner
|
Thank you! I will add new tag with this fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like SwiftGitX 0.1.7 pulls down your latest libgit2 fork release, 1.9.1 instead of 1.8.0 because the dependency rule in
Package.swiftwill choose the latest release of your libgit2 fork.This creates build errors for lines 30 and 31 in
ObjectType.swiftwhere thegit_object_tenum values cannot be found forGIT_OBJECT_OFS_DELTAandGIT_OBJECT_REF_DELTA.SwiftGitX/Sources/SwiftGitX/Models/Types/ObjectType.swift
Lines 30 to 31 in e190291
Setting the dependency to pull the exact version fixes the issue.
Maybe we should also pull exact versions for all the other versions too to prevent potential issues in the future?
Also sorry for the extra merge commit in this PR. I made the change on GitHub.com real quick and did it kind of hacky haha.
Thanks for your awesome library! :)