refact/create micro app#479
Merged
Merged
Conversation
Collaborator
maoxiaoke
commented
Dec 8, 2021
- refact createMicroApp api
ClarkXia
reviewed
Dec 8, 2021
|
|
||
| // Merge global configuration | ||
| const cfgs = globalConfiguration; | ||
| Object.keys(configuration || {}).forEach((key) => { |
Collaborator
There was a problem hiding this comment.
注释下这里引用赋值的原因，也可以考虑重构成 单独的 Configuration 类，提供 get 和 set 的方法
Collaborator
Author
There was a problem hiding this comment.
这里预期不是引用赋值，虽然老代码是引用赋值，但不是预期行为
|
|
||
| const appConfig = getAppConfig(appName); | ||
|
|
||
| if (!(appConfig && appName)) { |
Collaborator
There was a problem hiding this comment.
!appConfg || !appName 可能会更清晰点，不存在 appConfig 或者 appName 的时候直接报错
ClarkXia
approved these changes
Dec 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.