fix: effects should return an object#105
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## release/1.4.0 #105 +/- ##
=================================================
+ Coverage 87.91% 87.93% +0.02%
=================================================
Files 20 20
Lines 546 547 +1
Branches 121 121
=================================================
+ Hits 480 481 +1
Misses 56 56
Partials 10 10
|
luhc228
approved these changes
Apr 21, 2020
alvinhui
added a commit
that referenced
this pull request
Apr 24, 2020
* chore: new version * fix: add meta type in ModelEffects (#102) * Add @ice/store Unit Test (#84) * chore: add dependency * test: add helper and init test * test: add createStore test * test: add withModel withModelActions withModelEffectsState test * test: add throw error when getting unexist model * chore: new version * test: add global actions test * test: add createModel test * test: add createUseContainer test * chore: createModel * test: add createContainer test * test: update test cases * test: add useModel test * test: add class component test * test: update class component test * test: add createStore options test * test: add appendReducer test * test: add appendReducer test * chore: lint * test: add utils test * docs: add badge * chore: remove unnecessary comment * test: update converter test * feat: add comment to pr * fix: fix by the comments * chore: update codecov config * test: update test * test: update converter test case * test: update examples * test: update todos example * chore: update modelEffects type Co-authored-by: alvinhui <alvin.hui@qq.com> * fix: effects should return an object (#105) * fix: effects should return an object * chore: lint * Better example (#106) * chore: add classComponent example * chore: rename async function * chore: visibility logic * docs: add examples section * feat: withModel (#104) * feat: withModel init * refactor: model apis * feat: model for withModel * feat: ts support for withModel * chore: typo * chore: lint * test: disable loading and error * test: mock value * chore: playload && meta is option * chore: typo * docs: withModel * refactor: class and function component demo * chore: class component support * chore: remove console * chore: lint * chore: withModel example * chore: remove product * chore: undo * chore: typo * Docs: Migrating From Redux (#108) * chore: example @ice/store version Co-authored-by: Hengchang Lu <44047106+luhc228@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.