Skip to content

cps/editbooks.py: move instead of copyfile (for #45)#82

Merged
holta merged 1 commit into
iiab:masterfrom
holta:mv-not-cp
Dec 31, 2023
Merged

cps/editbooks.py: move instead of copyfile (for #45)#82
holta merged 1 commit into
iiab:masterfrom
holta:mv-not-cp

Conversation

@holta

@holta holta commented Dec 31, 2023

Copy link
Copy Markdown
Member

To avoid SD card wear, CPU / bus overuse, large videos/books/etc should always be moved not copied. Hopefully this PR goes a long way towards fixing this longstanding problem:

As tested on Ubuntu 24.04 pre-release.

@deldesir & All: please review after merge, in case this can be revised & improved upon!

Background... this PR supersedes:

@holta holta added the bug Something isn't working label Dec 31, 2023
@holta holta requested a review from deldesir December 31, 2023 05:50
@holta holta merged commit 10d537d into iiab:master Dec 31, 2023
@holta

holta commented Dec 31, 2023

Copy link
Copy Markdown
Member Author

FYI this PR still leaves orphan (empty) directories like:

/library/downloads/calibre-web/Youtube/CNBC
/library/downloads/calibre-web/Youtube/ESPN_College_Football
...

All such directories (as above) should definitely be removed, the moment after they're no long needed.

(Even if that's NOT the most urgent fix needed at this time — with far more serious bugs/issues needing immediate attention below...)

https://github.com/iiab/calibre-web/issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant