Skip to content

Enhance database operations for better debugging#96

Merged
holta merged 5 commits into
iiab:masterfrom
deldesir:deldesir-database
Jan 17, 2024
Merged

Enhance database operations for better debugging#96
holta merged 5 commits into
iiab:masterfrom
deldesir:deldesir-database

Conversation

@deldesir

@deldesir deldesir commented Jan 15, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

🚀 Pull Request Overview:

This pull request includes the following enhancements to the download task:

  • Improved error handling for download failures with detailed error messages.
  • Enhanced database operations to handle errors and provide clearer messages.
  • Improved retrieval of requested files and shelf title from the SQLite database.

These changes aim to make the download process more robust and provide users with better information about download failures.

📋 Checklist:

  • Tested the changes thoroughly.
  • Checked for backward compatibility (bookshelf feature)

🔗 Related Issues:
Issue #89

📌 Testing scenarios:
See Issue #97

cc @EMG70

@deldesir deldesir added the enhancement New feature or request label Jan 15, 2024
@deldesir deldesir requested a review from holta January 15, 2024 05:30
@deldesir deldesir self-assigned this Jan 15, 2024
@deldesir deldesir marked this pull request as draft January 15, 2024 05:35
@deldesir deldesir mentioned this pull request Jan 15, 2024
Open
@holta

holta commented Jan 16, 2024

Copy link
Copy Markdown
Member

  1. @deldesir how does this quick test of PR Enhance database operations for better debugging #96 look to you?

    iiab-diagnostics: https://sprunge.us/16LYXQ?en#n-873

  2. What aspects of PR Enhance database operations for better debugging #96 should @EMG70 test most urgently on Tuesday (i.e. in coming hours, if he happens to have time!!)

  3. ASIDE: Are /var/log/calibre-web.log blank lines on 962 and 1001 something we should clean up? (Or is that an upstream Calibre-Web issue we should not get involved with for now?)

@deldesir deldesir marked this pull request as ready for review January 16, 2024 13:22
@deldesir

deldesir commented Jan 16, 2024

Copy link
Copy Markdown
Member Author
  1. @deldesir how does this quick test of PR Enhance database operations for better debugging #96 look to you?
    iiab-diagnostics: https://sprunge.us/16LYXQ?en#n-873

Looks clean to me. With this info, we know which commits/PR is being tested

  1. What aspects of PR Enhance database operations for better debugging #96 should @EMG70 test most urgently on Tuesday (i.e. in coming hours, if he happens to have time!!)

Backward compatibility, ensuring playlists download without an itch.

  1. ASIDE: Are /var/log/calibre-web.log blank lines on 962 and 1001 something we should clean up? (Or is that an upstream Calibre-Web issue we should not get involved with for now?)

Not very important, but we'll keep an eye to it so someday we can look into it.

@holta holta mentioned this pull request Jan 16, 2024
Closed
@holta

holta commented Jan 16, 2024

Copy link
Copy Markdown
Member

3. What aspects of PR Enhance database operations for better debugging #96 should @EMG70 test most urgently on Tuesday (i.e. in coming hours, if he happens to have time!!)

Backward compatibility, ensuring playlists download without an itch.

@deldesir Are you saying this PR #96 solves... ?

(Thanks for clarifying & explaining so there's no ambiguity!)

@deldesir

deldesir commented Jan 16, 2024

Copy link
Copy Markdown
Member Author

Yes, but not without #99

@holta

holta commented Jan 16, 2024

Copy link
Copy Markdown
Member

Yes, but not without #99

Motivations behind PR #99 are not (yet!) clear to me and @EMG70:

If it's blocking testing or other PR's (not great, but Ok!) then please prioritize helping everyone in understanding PR #99's motivations, Thank You! 💯

@holta holta mentioned this pull request Jan 16, 2024
Closed
2 tasks
@holta

holta commented Jan 17, 2024

Copy link
Copy Markdown
Member

PR #99 appears to contain serious problems based on a misunderstanding as to where we are headed:

So hopefully merging this PR #96 can serve as a basis for reworking PR #99 — moving us all (baby steps! one step at a time!) — towards what's actually needs... 🙏

@holta holta merged commit 23dde79 into iiab:master Jan 17, 2024
This was referenced Jan 19, 2024
Merged
Closed
@avni avni mentioned this pull request Jan 20, 2024
Closed
@deldesir deldesir deleted the deldesir-database branch July 1, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@holta holta Awaiting requested review from holta

Assignees

@deldesir deldesir

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@deldesir @holta