Skip to content

uploader.py: Put "Original Internet URL" under description#185

Merged
holta merged 1 commit into
iiab:masterfrom
holta:url-below-desc
Jun 14, 2024
Merged

uploader.py: Put "Original Internet URL" under description#185
holta merged 1 commit into
iiab:masterfrom
holta:url-below-desc

Conversation

@holta

@holta holta commented Jun 14, 2024

Copy link
Copy Markdown
Member

@holta holta added the enhancement New feature or request label Jun 14, 2024
@holta holta requested a review from deldesir June 14, 2024 14:06
@holta

holta commented Jun 14, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

Tested on LRN2 (Ubuntu 24.04).

BEFORE...

image

AFTER...

image

deldesir
deldesir approved these changes Jun 14, 2024
View reviewed changes

@deldesir deldesir left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@holta holta merged commit 9e7f0bf into iiab:master Jun 14, 2024
@holta

holta commented Jun 14, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

@deldesir

  1. I inserted the word "Internet" within "Original Internet URL:" to help educators/kids understand that the original video came from the ONline Internet...

  2. But what happens with this code when the original was an OFFline (local, grassroots community) video[*] — do you know?

[*] Or possibly even original OFFline photo??

@holta holta mentioned this pull request Jun 14, 2024
Open
@holta

holta commented Jun 14, 2024

Copy link
Copy Markdown
Member Author

Probably better to follow up on this open ticket / design ticket:

@deldesir

deldesir commented Jun 14, 2024 •
edited
Loading

Copy link
Copy Markdown
Member
  1. I inserted the word "Internet" within "Original Internet URL" to help educators/kids understand that the original video came from the ONline Internet...

That explains it.

  1. But what happens with this code when the original video came from an OFFline (local, grassroots community) video — do you know?

An offline resource shared would be better identifiable by the the publisher name IMO. Could be an individual, an institution...

@holta

holta commented Jun 14, 2024

Copy link
Copy Markdown
Member Author

I've followed up here:

@holta

holta commented Jul 5, 2024

Copy link
Copy Markdown
Member Author

This PR puts ugly, raw HTML tags <br><br> (visible to all users) in many-if-not-most cases.

This really should be fixed, as outlined at:

@deldesir

deldesir commented Jul 11, 2024

Copy link
Copy Markdown
Member

This PR puts ugly, raw HTML tags <br><br> (visible to all users) in many-if-not-most cases.

This really should be fixed, as outlined at:

This regression is fixed by commit from upstream janeczku@551828f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deldesir deldesir deldesir approved these changes

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@holta @deldesir