Load required jQuery in noConflict mode #357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We are seeking comments on this from any OpenWayback users who have an opinion on retaining the scrollbar added to the toolbar in #341 (which requires jQuery). This PR should prevent jQuery conflicts with the toolbar and archived page content. An alternative to this PR is reverting the toolbar back to what it was without the scrollbar, meaning jQuery will not be loaded by the toolbar. I have tried the fix in this PR, and it worked for me to fix an issue where the 1.4.2 version loaded by the Toolbar was preventing something in an archived page working because it needed 1.7.2 version of jQuery. By the way @jason-ellis is a programmer for User Interfaces at UNT Libraries. |
MohammedElsayyed
approved these changes
Sep 19, 2017
ldko
added a commit
that referenced
this pull request
Sep 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Load jQuery 1.4.2 and toolbar plugin, then define new jQuery global (
jqWayback) and relinquish control of$global to prevent interference with archived page jQuery.Fixes #356