Feature/checkout configuration #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The checkout action before running the actual docker-ros pipeline makes it difficult to move in files/directories for docker-ros to use which are not present in the repository itself (e.g. artifacts produced by other jobs/workflows).
Additionally, the option
lfs: trueof the checkout action leads to a failed pipeline if the executing runner doesn't have git-lfs installed. It makes sense to leave this up to the user, especially if they use self-hosted runners.These changes allow users to manually disable the checkout action, as well as its git lfs support. Defaults are set to 'true', so existing pipelines based on docker-ros should show no change in behavior.