Skip to content

Should XRInputSource.profiles changes fire an XRInputSourcesChangeEvent? #783

Closed
#795
Closed
Should XRInputSource.profiles changes fire an XRInputSourcesChangeEvent?#783
#795
Assignees
tojiManishearth
Labels
fixed by pending PRA PR that is in review will resolve this issue.help wantedThis is a good issue for anyone to pick up and work on filing a PR for.
Milestone
August 2019

Description

@jacobcdewitt
jacobcdewitt
opened on Jul 30, 2019

The spec says "When the handedness, targetRayMode, or presence of a gripSpace or gamepad for any XR input sources change for XRSession session, the user agent MUST run the following steps". Would it also make sense to re-create the input source and fire an event when the contents of the profiles array changes?

Activity

  1. jacobcdewitt commented on Jul 30, 2019

    @jacobcdewitt
    jacobcdewitt
    on Jul 30, 2019
    Author

    It's worth noting that the profiles is a FrozenArray, which means it probably shouldn't be updated in-place by the browser. Since it also has the [SameObject] attribute, re-creating the XRInputSource seems like the only compliant solution for when the profiles array changes.

    @toji , what are your thoughts on this?

  2. toji commented on Jul 31, 2019

    @toji
    toji
    on Jul 31, 2019
    Member

    Yes.

  3. toji
    added this to the August 2019 milestone on Jul 31, 2019
  4. toji
    self-assigned this
    on Jul 31, 2019
  5. NellWaliczek
    added
    help wantedThis is a good issue for anyone to pick up and work on filing a PR for.
    on Jul 31, 2019
  6. NellWaliczek
    modified the milestones: August 2019, September 2019 on Jul 31, 2019
  7. chromium-wpt-export-bot
    added 2 commits that reference this issue on Aug 8, 2019

    Recreate XRInputSource when profiles change.

    ca5ea35

    Recreate XRInputSource when profiles change.

    d84da8c
  8. aarongable
    added a commit that references this issue on Aug 12, 2019

    Recreate XRInputSource when profiles change.

    841569f
  9. chromium-wpt-export-bot
    added 2 commits that reference this issue on Aug 12, 2019

    Recreate XRInputSource when profiles change.

    32d46fe

    Recreate XRInputSource when profiles change.

    f6819af
  10. Manishearth
    self-assigned this
    on Aug 13, 2019

  11. Manishearth commented on Aug 13, 2019

    @Manishearth
    Manishearth
    on Aug 13, 2019
    Contributor

    #795

  12. Manishearth
    added
    fixed by pending PRA PR that is in review will resolve this issue.
    on Aug 13, 2019
  13. toji
    closed this as completedin #795on Aug 13, 2019
  14. toji
    modified the milestones: September 2019, August 2019 on Aug 13, 2019
  15. moz-v2v-gh
    added a commit that references this issue on Aug 15, 2019

    Bug 1573257 [wpt PR 18338] - Recreate XRInputSource when profiles cha…

    614b7a6
  16. xeonchen
    added a commit that references this issue on Aug 15, 2019

    Bug 1573257 [wpt PR 18338] - Recreate XRInputSource when profiles cha…

    18ca7f3
  17. natechapin
    added a commit that references this issue on Aug 23, 2019

    Recreate XRInputSource when profiles change.

    aeca673
  18. gecko-dev-updater
    added 3 commits that reference this issue on Oct 4, 2019

    Bug 1573257 [wpt PR 18338] - Recreate XRInputSource when profiles cha…

    7a575cc

    Bug 1573257 [wpt PR 18338] - Recreate XRInputSource when profiles cha…

    93ad66d

    Bug 1573257 [wpt PR 18338] - Recreate XRInputSource when profiles cha…

    f1a51f1
  19. bhearsum
    added a commit that references this issue on May 1, 2025

    Bug 1573257 [wpt PR 18338] - Recreate XRInputSource when profiles cha…

    f274993
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

fixed by pending PRA PR that is in review will resolve this issue.help wantedThis is a good issue for anyone to pick up and work on filing a PR for.

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions