Skip to content

Context loss handling in makeXRCompatible does not make sense #913

Closed

Description

@bzbarsky

https://immersive-web.github.io/webxr/#dom-webglrenderingcontextbase-makexrcompatible step 1.8.1 says:

Force context to be lost and handle the context loss as described by the WebGL specification.

where "handle the context loss" links to https://www.khronos.org/registry/webgl/specs/latest/1.0/#CONTEXT_LOST

Those steps set some flags, then queue a task to fire an event. But step 1.8.2 seems to assume the event has already fired (it hasn't; there's just a task queued to fire it). Furthermore, when that task runs, it will restore the drawing buffer, but step 1.8.3 does that too.

This section seems like it wants to reuse parts of the default webgl behavior, but not all of it. The right way to do this is probably to factor out the to-be-shared behavior (if possible), or something. But the current setup really doesn't make sense.

Activity

  1. added this to the November 2019 milestone on Nov 18, 2019
  2. added
    help wantedThis is a good issue for anyone to pick up and work on filing a PR for.
    on May 8, 2020
  3. self-assigned this
    on Jul 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

help wantedThis is a good issue for anyone to pick up and work on filing a PR for.

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions