Conversation
Summary of ChangesHello @kazukokawagawa, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 此拉取请求修复了一个问题，即即使启用了隐藏歌词括号的用户设置，专辑名称也未能正确地剔除括号。此更改确保了专辑标题在不同的 UI 组件中能根据用户偏好一致地显示。 Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
| settingStore.hideLyricBrackets | ||
| ? removeBrackets(song.album?.name) | ||
| : song.album?.name || "未知专辑" |
There was a problem hiding this comment.
当前逻辑存在一个缺陷：当 settingStore.hideLyricBrackets 为 true 且 song.album?.name 为空时，会显示一个空字符串，而不是预期的“未知专辑”。为了修复这个问题，并使代码更简洁，建议将 || "未知专辑" 的备选逻辑移到三元表达式之外。
(settingStore.hideLyricBrackets
? removeBrackets(song.album?.name)
: song.album?.name) || "未知专辑"
| settingStore.hideLyricBrackets | ||
| ? removeBrackets(song.album) | ||
| : song.album || "未知专辑" |
There was a problem hiding this comment.
同样的问题：当 song.album 为空且 hideLyricBrackets 开启时，会显示空字符串而不是“未知专辑”。
(settingStore.hideLyricBrackets
? removeBrackets(song.album)
: song.album) || "未知专辑"
| settingStore.hideLyricBrackets | ||
| ? removeBrackets(musicStore.playSong.album?.name) | ||
| : musicStore.playSong.album?.name || "未知专辑" |
There was a problem hiding this comment.
此处的逻辑也存在缺陷。当 settingStore.hideLyricBrackets 为 true 且 musicStore.playSong.album?.name 为空时，会显示一个空字符串，而不是“未知专辑”。建议将 || "未知专辑" 移到三元表达式之外来修复此问题。
(settingStore.hideLyricBrackets
? removeBrackets(musicStore.playSong.album?.name)
: musicStore.playSong.album?.name) || "未知专辑"
| settingStore.hideLyricBrackets | ||
| ? removeBrackets(musicStore.playSong.album) | ||
| : musicStore.playSong.album || "未知专辑" |
There was a problem hiding this comment.
同样的问题：当 musicStore.playSong.album 为空且 hideLyricBrackets 开启时，会显示空字符串而不是“未知专辑”。
(settingStore.hideLyricBrackets
? removeBrackets(musicStore.playSong.album)
: musicStore.playSong.album) || "未知专辑"
🦄 refactor: 全局设置重构，支持搜索 / 跳转
No description provided.