Fix #557: Don't try to print compiled regexes as strings#558
Merged
Conversation
elbrujohalcon
commented
Feb 20, 2026
NelsonVides
approved these changes
Feb 20, 2026
NelsonVides
left a comment
Collaborator
There was a problem hiding this comment.
Right, the precompiled regex, good catch!
elbrujohalcon
added a commit
that referenced
this pull request
Feb 25, 2026
* Fix #557: Don't try to print compiled regexes as strings (#558) Elvis was failing to generate results for atom_naming_convention since it was trying to "print" a compiled regex as a string (~ts). * Hopefully optimize `elvis_code:find/4` (#559) * Hopefully optimize `elvis_code:find/4` * Adjust comment * Slim out lines * Invert condition checking * Slim things up again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Elvis was failing to generate results for
atom_naming_conventionsince it was trying to "print" a compiled regex as a string (~ts).Closes #557.