Feature/handle gundown#197
Conversation
elbrujohalcon
left a comment
There was a problem hiding this comment.
It's not bad but you seem to be using tabs for indentation and that breaks code style.
If you, instead of realigning everything manually, would like to add rebar3_format to this project and format the code according to its rules, that would be perfectly fine, too.
|
Hummm… In order to see only the relevant changes here, I applied the formatter independently in #198 … but it looks I didn't do it correctly, did I? 🤔 |
|
Fixed :) |
elbrujohalcon
left a comment
There was a problem hiding this comment.
A few comment removals, but everything else looks fine.
…k/shotgun into feature/handle_gundown
|
|
That's interesting. I added the plugin without any specific options, see rebar.config. |
|
Please tag the new version with 1.1.0. |
|
Why have you closed this PR, @mkrusemark ? |
|
I'm confident it's a good change. I'll reopen and merge it. |
|
Added support for reconnection via a shotgun:reopen call.
Testsuites had to be modified because cover didn't work with latest erlang version.
Rebar3 crashed with rich compiler messages.