Resolve EPD.init argument error for Waveshare v3#22
Merged
Conversation
Closed
Contributor
Author
|
All errors for the Waveshare V3 should now be resolved following the two commits in this PR. |
Owner
|
Thanks mate, have you tried it ? |
Contributor
Author
|
Yup, this does work. @ZeroCool-Dade was also able to confirm under the issues page: |
infinition
approved these changes
Nov 12, 2024
Owner
infinition
left a comment
There was a problem hiding this comment.
Solved compatibility issue for EPD v3 thanks @[jbohack]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the Waveshare v3 crashing loop. After applying this merge, the screen will refresh as expected. Crash logs prior listed below:
Nov 11 15:05:33 bjorn python3[9918]: TERM environment variable not set.
Nov 11 15:05:33 bjorn python3[9913]: 2024-11-11 15:05:33 - shared.py - INFO - Loading configuration...
Nov 11 15:05:35 bjorn systemd[1]: Stopping bjorn.service - Bjorn Service...
Nov 11 15:05:35 bjorn systemd[1]: bjorn.service: Deactivated successfully.
Nov 11 15:05:35 bjorn systemd[1]: Stopped bjorn.service - Bjorn Service.
Nov 11 15:05:35 bjorn systemd[1]: bjorn.service: Consumed 3.058s CPU time.
Nov 11 15:05:35 bjorn systemd[1]: Starting bjorn.service - Bjorn Service...
Nov 11 15:05:35 bjorn systemd[1]: Started bjorn.service - Bjorn Service.
Nov 11 15:05:36 bjorn python3[9986]: TERM environment variable not set.
Nov 11 15:05:36 bjorn python3[9942]: 2024-11-11 15:05:36 - shared.py - INFO - Loading configuration...
Nov 11 15:05:40 bjorn python3[9942]: 2024-11-11 15:05:39 - shared.py - INFO - Web console log file not found at
Nov 11 15:05:40 bjorn python3[9942]: /home/bjorn/Bjorn/data/logs/temp_log.txt ...
Nov 11 15:05:40 bjorn python3[9942]: 2024-11-11 15:05:40 - shared.py - INFO - Initializing the network knowledge base
Nov 11 15:05:40 bjorn python3[9942]: CSV file with headers
Nov 11 15:05:40 bjorn python3[9942]: 2024-11-11 15:05:40 - shared.py - INFO - Network knowledge base CSV file already
Nov 11 15:05:40 bjorn python3[9942]: exists at /home/bjorn/Bjorn/data/netkb.csv
Nov 11 15:05:40 bjorn python3[9942]: 2024-11-11 15:05:40 - shared.py - INFO - Initializing EPD display...
Nov 11 15:05:41 bjorn python3[9942]: 2024-11-11 15:05:41 - shared.py - INFO - EPD type: epd2in13_V3 screen reversed
Nov 11 15:05:41 bjorn python3[9942]: Error initializing EPD for full update: EPD.init() takes 1 positional argument but 2 were given
Nov 11 15:05:41 bjorn python3[9942]: 2024-11-11 15:05:41 - shared.py - ERROR - Error initializing EPD display:
Nov 11 15:05:41 bjorn python3[9942]: EPD.init() takes 1 positional argument but 2 were given
Nov 11 15:05:41 bjorn python3[9942]: Traceback (most recent call last):
Nov 11 15:05:41 bjorn python3[9942]: File "/home/bjorn/Bjorn/Bjorn.py", line 24, in
Nov 11 15:05:41 bjorn python3[9942]: from init_shared import shared_data
Nov 11 15:05:41 bjorn python3[9942]: File "/home/bjorn/Bjorn/init_shared.py", line 13, in
Nov 11 15:05:41 bjorn python3[9942]: shared_data = SharedData()
Nov 11 15:05:41 bjorn python3[9942]: ^^^^^^^^^^^^
Nov 11 15:05:41 bjorn python3[9942]: File "/home/bjorn/Bjorn/shared.py", line 38, in init
Nov 11 15:05:41 bjorn python3[9942]: self.setup_environment() # Setup the environment
Nov 11 15:05:41 bjorn python3[9942]: ^^^^^^^^^^^^^^^^^^^^^^^^
Nov 11 15:05:41 bjorn python3[9942]: File "/home/bjorn/Bjorn/shared.py", line 170, in setup_environment
Nov 11 15:05:41 bjorn python3[9942]: self.initialize_epd_display()
Nov 11 15:05:41 bjorn python3[9942]: File "/home/bjorn/Bjorn/shared.py", line 192, in initialize_epd_display
Nov 11 15:05:41 bjorn python3[9942]: self.epd_helper.init_full_update()
Nov 11 15:05:41 bjorn python3[9942]: File "/home/bjorn/Bjorn/epd_helper.py", line 30, in init_full_update
Nov 11 15:05:41 bjorn python3[9942]: self.epd.init(self.epd.lut_full_update)
Nov 11 15:05:41 bjorn python3[9942]: TypeError: EPD.init() takes 1 positional argument but 2 were given
Nov 11 15:05:42 bjorn systemd[1]: bjorn.service: Main process exited, code=exited, status=1/FAILURE
Nov 11 15:05:42 bjorn systemd[1]: bjorn.service: Failed with result 'exit-code'.