feat/refactor/fix: Web Search Enhancements, Settings Improvements & Bug Fixes#91
Closed
travertexs wants to merge 11 commits into
Closed
feat/refactor/fix: Web Search Enhancements, Settings Improvements & Bug Fixes#91travertexs wants to merge 11 commits into
travertexs wants to merge 11 commits into
Conversation
Group web search related settings under a single webSearchSettings object for better organization. Additionally, it introduces a new setting urlFetchBackend to control whether Jina or a local parser is used for fetching URL content.
merge changes from `file-search-fix` branch
This commit refactors the `parseInfioSettings` function to fix issues in error handling during settings migration, addressing issues that caused test failures. The changes also prevent excessive error logging in the terminal.
This commit introduces support for various web search backends, providing users with more options within the plugin. Key Changes: - Added multiple new search backends - Modified the settings tab to include dropdown menus for selecting the preferred web search backends, along with corresponding API key input fields where necessary. Current Supported Search Backends: - SerpAPI - Scrapingdog - Serper - Jina - DuckDuckGo, - Brave
This commit introduces a major refactoring of the settings schema to improve organization, maintainability, and future extensibility. Key changes: - Renamed `filesSearchSettings` to `fileSearchSettings` - `migrateSettings` function is now moved to `migration.ts`. It can correctly handle schema migrations from older versions to the current one. - Older, unused setting fields are now explicitly marked as deprecated within the settings schema to maintain backward compatibility while facilitating cleaner code. - `DEFAULT_SETTINGS` has been updated to reflect the new structure, with some common schemas moved or reorganized. - Tests for settings parsing have been updated to validate the new schema and migration logic.
Key Changes: - Moved `SETTINGS_SCHEMA_VERSION` and `DeprecatedSettingsSchema` to `shared.ts`. This resolves a circular dependency, ensuring `SETTINGS_SCHEMA_VERSION` is correctly defined when migration objects are initialized. - Simplified conditional checks within individual migration functions. - Modified `parseInfioSettings` to first attempt strict parsing of current settings, deferring to the migration process only when an older or non-standard format is detected.
…ck-duck-scrape` This commit temporarily hide the DuckDuckGo search option from the settings. This is due to unresolved issues with `duck-duck-scrape`.
Member
|
hi travertexs I still couldn't properly merge your last submission, so I started over from version 0.6.10 Can you use rebase instead of merge? This would greatly improve my review/testing efficiency. |
Member
|
If it's an error from settings.test, you can ignore it for now—there's currently an issue with the testing here. I can manually test and modify this part. You can add your own file search test file as long as it ensures normal functionality. Thanks again! |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes a series of updates focusing on improving web search capabilities, enhancing settings management, and addressing various bug fixes and refactorings.
Key Changes:
duck-duck-scrape.Checklist before requesting a review
pnpm run test)