Skip to content

quick fix #602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Tim-Linschoten merged 1 commit into from
Jul 14, 2020
Merged

quick fix #602

Tim-Linschoten merged 1 commit into from
Jul 14, 2020

Conversation

@VledicFranco
Copy link
Contributor

@VledicFranco VledicFranco commented Jul 14, 2020

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2020

Codecov Report

Merging #602 into master will decrease coverage by 0.82%.
The diff coverage is 69.86%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #602      +/-   ##
==========================================
- Coverage   78.04%   77.22%   -0.83%     
==========================================
  Files         120      122       +2     
  Lines        3913     3986      +73     
  Branches       90       97       +7     
==========================================
+ Hits         3054     3078      +24     
- Misses        859      908      +49
Impacted Files Coverage Δ
...com/ing/baker/baas/interaction/HealthService.scala 0.00% <0.00%> (ø)
...in/scala/com/ing/baker/baas/interaction/Main.scala 0.00% <0.00%> (ø)
...ker/baas/interaction/RemoteInteractionLoader.scala 0.00% <0.00%> (ø)
...cala/com/ing/baker/baas/state/KafkaEventSink.scala 18.18% <ø> (ø)
...src/main/scala/com/ing/baker/baas/state/Main.scala 0.00% <0.00%> (ø)
...ry/clustercontroller/BakeryControllerService.scala 0.00% <0.00%> (ø)
.../scala/com/ing/bakery/clustercontroller/Main.scala 0.00% <0.00%> (ø)
...y/clustercontroller/MutualAuthKeystoreConfig.scala 0.00% <0.00%> (ø)
...lustercontroller/controllers/BakerController.scala 86.32% <71.42%> (-2.36%) ⬇️
...ing/baker/runtime/serialization/JsonDecoders.scala 88.46% <77.77%> (-7.00%) ⬇️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94ff1cd...3341b27. Read the comment docs.

@Tim-Linschoten Tim-Linschoten merged commit 8d7dc47 into master Jul 14, 2020
@VledicFranco VledicFranco deleted the json-bug branch September 3, 2020 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Tim-Linschoten Tim-Linschoten Tim-Linschoten approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@VledicFranco @codecov-commenter @Tim-Linschoten