Skip to content

better kafka sink #893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jacum merged 9 commits into from
Apr 22, 2021
Merged

better kafka sink #893

jacum merged 9 commits into from
Apr 22, 2021

Conversation

@jacum
Copy link
Contributor

@jacum jacum commented Apr 21, 2021

safe and simple kafka sink that logs just events, no ingredients

  • possible to override implementations

@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2021

Codecov Report

Merging #893 (76f8fd5) into master (69d3fba) will increase coverage by 2.83%.
The diff coverage is 13.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #893      +/-   ##
==========================================
+ Coverage   79.27%   82.10%   +2.83%     
==========================================
  Files         123      105      -18     
  Lines        3976     3476     -500     
  Branches      105      106       +1     
==========================================
- Hits         3152     2854     -298     
+ Misses        824      622     -202
Impacted Files Coverage Δ
...a/com/ing/baker/runtime/akka/AkkaBakerConfig.scala 76.27% <ø> (ø)
...rc/main/scala/com/ing/bakery/baker/EventSink.scala 13.33% <13.33%> (ø)
...lization/protomappings/CompiledRecipeMapping.scala
...rialization/protomappings/EventMomentMapping.scala
...ialization/protomappings/ProcessStateMapping.scala
...tomappings/InteractionFailureStrategyMapping.scala
.../protomappings/EventOutputTransformerMapping.scala
...lization/protomappings/BakerExceptionMapping.scala
...erialization/protomappings/BakerEventMapping.scala
...rialization/protomappings/BakerValuesMapping.scala
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69d3fba...76f8fd5. Read the comment docs.

@jacum jacum merged commit 0bba535 into master Apr 22, 2021
@jacum jacum deleted the feature/better-kafka-sink branch April 22, 2021 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@stasimus stasimus stasimus approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jacum @codecov-commenter @stasimus