Interaction binding updates #926
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mentations if the output is available on the implementation. Fixed the LocalInteractionsSpec to do validations (the validation was not executed).
… implementations on interactions.
…F code. Added output biding for runtime events that have the @FireEvent annotation. Moved the annotations to a seperate package so the runtime can reuse the same annotations.
Fixed the output binding for interaction instances.
Added correct error messages for the compatibility check.
…tor object that complies to our typesafe interface instead of the InteractionExecution.Descriptor.
Added binding of the interaction input names if available.
# Conflicts: # bakery/baker-state/src/main/scala/com/ing/bakery/baker/BakerService.scala # bakery/state/src/test/scala/com/ing/bakery/baker/StateRuntimeSpec.scala
Codecov Report
@@ Coverage Diff @@
## master #926 +/- ##
==========================================
- Coverage 81.95% 81.92% -0.04%
==========================================
Files 108 109 +1
Lines 3602 3629 +27
Branches 106 106
==========================================
+ Hits 2952 2973 +21
- Misses 650 656 +6
Continue to review full report at Codecov.
|
jacum
previously approved these changes
May 17, 2021
jacum
approved these changes
May 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now extracts the input names and output events if annotations are present for the implementation.
Ensured these fields are used in the compatability function.
Updated the getImplementation to comply to our Baker interface language setup so it supports both Java & Scala correctly.