updated cli to remove unneeded project flag#898
Conversation
🦋 Changeset detectedLatest commit: ad9f31a The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
Claude finished @tim-inkeep's task —— View job TypeScript Staff Engineer ReviewTodo List
Review SummaryThis PR removes an "unneeded project flag" by refactoring the Architecture & Design Improvements ✅Excellent Pattern ConsistencyThe changes align the
This eliminates a significant UX friction point and follows the DRY principle by reusing existing utilities. Smart Refactoring Decisions
Code Quality Assessment ✅Clean Implementation
Proper Error Boundaries
Customer Impact Assessment ✅Positive Breaking Change
Backward Compatibility MaintainedThe // Before: 'Project ID to pull from backend'
// After: 'Override project ID (defaults to local project ID from index.ts)'Technical Considerations ✅Performance Impact: Minimal
Security: No concerns
System Design Validation ✅Consistent CLI PatternsThis change makes the CLI commands more cohesive:
Future ExtensibilityThe refactoring positions the codebase well for future enhancements:
Minor ConsiderationsDocumentation Gap:The PR description is empty. Consider adding:
Missing Changeset:As noted by the changeset bot, this appears to be a user-facing change that would benefit from a changelog entry. Recommendation: APPROVE ✅This is a thoughtful refactoring that:
The implementation follows established patterns and best practices. No architectural concerns or code quality issues identified. |
…#898) (inkeep#3268) * Introduce check:fast tier for in-vivo agent verification (G1) Closes G1 from the merge-gates audit (inkeep#892): "No check:fast script tier — Layer 1 (in-vivo) is undocumented for agents." Adds `check:fast` as the canonical fast-verification command name across root + 6 subtrees. Aliased to each subtree's existing `typecheck` (the fastest reliable signal of real errors). Agents doing in-vivo iteration inside a subtree can now run `pnpm check:fast` (or `bun run check:fast` in OK) regardless of subtree — same command name, subtree-appropriate implementation. Scope: - Root `check:fast` fans out to all 6 subtrees with typecheck coverage (matches existing `typecheck` root fan-out shape) - Per-subtree `check:fast` script added; each aliases the subtree's existing typecheck command verbatim (no behavior change, just a named alias for discoverability) - subtrees: public/agents, public/open-knowledge, private/agents-ui, private/chat-to-edit, private/copilot-app, private/copilot-chrome-extension Why typecheck and not something broader: - typecheck catches the most common in-vivo error (type mismatches, missing imports, broken refactors) with cache hits in <10s warm - No tests: tests are slow and not in-vivo-fast - No lint: lint is fast but typecheck already covers most real bugs - No format:check: pre-commit's lint-staged covers that This is naming, not new behavior. If we later want check:fast to mean something different (e.g., typecheck + lint), the alias changes in one place per subtree. The name is the durable contract; the implementation is a script value. Local verification: `pnpm --dir public/agents check:fast` runs `turbo typecheck` correctly, 5.2s with 14/16 cached. (One pre-existing typecheck error in agents-manage-ui — react-google-recaptcha-v3 types missing — surfaced; that's on main, unrelated to this PR.) Follow-up: update .github/QUALITY_GATES.md Layer 1 to reference `check:fast` once inkeep#892 lands (QUALITY_GATES.md doesn't exist on this branch yet — it's introduced by inkeep#892). * Address PR inkeep#898 review: fold check:fast → typecheck alias (eliminates drift risk) pullfrog[bot] flagged that the previous shape duplicated each subtree's typecheck command verbatim under a `check:fast` key — 6 independent string literals had to stay in lockstep with the matching `typecheck` strings. A future PR changing a subtree's `typecheck` (e.g. adding a `--filter` exclusion) could silently forget the `check:fast` twin and the two would diverge. Fix: each subtree's `check:fast` now invokes `pnpm typecheck` (or `bun run typecheck` for OK) — a literal alias of the existing typecheck script in the same package.json. The typecheck script stays canonical; check:fast is its discoverable name. Single source of truth per subtree, zero drift surface. Per-subtree: - public/agents: `check:fast: pnpm typecheck` (delegates to existing `typecheck: turbo typecheck --filter='!agents-cookbook-templates'`) - public/open-knowledge: `check:fast: bun run typecheck` (delegates to existing `typecheck: turbo run typecheck`) - private/agents-ui: `check:fast: pnpm typecheck` - private/chat-to-edit: `check:fast: pnpm typecheck` - private/copilot-app: `check:fast: pnpm typecheck` - private/copilot-chrome-extension: `check:fast: pnpm typecheck` Local verification (alias chain runs end-to-end): - `pnpm --dir public/agents check:fast` → invokes typecheck → 16/16 turbo tasks success, 14/16 cached, 1m3s cold - `pnpm --dir private/agents-ui check:fast` → recursive typecheck across packages/agents-ui, packages/react, packages/docusaurus — all green (pullfrog's second finding about other AGENTS.md docs still referencing `pnpm typecheck`: addressed in PR body reply — keeping deferred since the alias means existing docs aren't wrong, just don't surface the new name.) GitOrigin-RevId: 86ed0df4b6e7d9fa68bd67adb0df85661f61e055 Co-authored-by: Varun Varahabhotla <vnv-varun@users.noreply.github.com>
No description provided.