fix: add missing env vars to turbo.json globalEnv#1932
fix: add missing env vars to turbo.json globalEnv#1932victor-inkeep wants to merge 1 commit intomainfrom
Conversation
Adds INKEEP_AGENTS_API_URL, NANGO_SECRET_KEY, PUBLIC_INKEEP_AGENTS_API_URL, GOOGLE_CLIENT_SECRET, PUBLIC_GOOGLE_CLIENT_ID, TRUSTED_ORIGIN, INKEEP_AGENTS_MANAGE_API_BYPASS_SECRET, INKEEP_AGENTS_MANAGE_UI_PASSWORD, and ENABLE_AUTHZ to turbo.json globalEnv so Vercel builds can access them. Without these, Turbo strips the env vars from the build environment causing build warnings and potential runtime failures.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
|
No docs changes detected - this is an internal build configuration fix for Turborepo environment variables. |
There was a problem hiding this comment.
PR Review Summary
(0) Total Issues | Risk: Low
This PR correctly adds 9 environment variables to Turbo's globalEnv array to ensure they are passed through to builds and affect cache invalidation. The changes are straightforward and appropriate.
💭 Consider (2) 💭
💭 1) turbo.json:25 ENABLE_AUTHZ has no current source code usage
Issue: The ENABLE_AUTHZ variable is being added to globalEnv, but grep across the codebase found no actual usage of this variable in any source code files.
Why: Adding unused env vars to globalEnv is low-risk but introduces drift between configuration and actual code. If this is intentional for a future feature, that's fine — just worth confirming.
Fix: Verify this is intentionally forward-looking. If not needed yet, consider removing it from this PR.
💭 2) .env.example Some added vars are undocumented for self-hosting
Issue: Several variables being added to globalEnv aren't documented in .env.example:
GOOGLE_CLIENT_SECRET/PUBLIC_GOOGLE_CLIENT_ID(used inagents-api/src/index.tsfor Google OAuth)TRUSTED_ORIGIN(defined inpackages/agents-core/src/env.ts)ENABLE_AUTHZ(if it has planned use)
Why: Self-hosters rely on .env.example as the canonical configuration template. When globalEnv grows out of sync, it creates confusion.
Fix: Consider a follow-up PR to document these variables in .env.example.
✅ APPROVE
Summary: Clean build configuration fix. The 9 env vars are legitimately used across the codebase (confirmed via grep across 111+ files) and declaring them in globalEnv is the correct fix for Vercel build warnings. The two "Consider" items are minor documentation suggestions that don't block this PR. Ship it! 🚀
Discarded (1)
| Location | Issue | Reason Discarded |
|---|---|---|
turbo.json:17-26 |
Trailing comma convention is correct | Positive observation, not actionable |
Reviewers (1)
| Reviewer | Returned | Main Findings | Consider | While You're Here | Inline Comments | Pending Recs | Discarded |
|---|---|---|---|---|---|---|---|
pr-review-devops |
3 | 0 | 2 | 0 | 0 | 0 | 1 |
| Total | 3 | 0 | 2 | 0 | 0 | 0 | 1 |
Summary
Adds 9 missing environment variables to
turbo.jsonglobalEnvthat are set on Vercel but were not declared in Turbo's configuration. Without these, Turbo strips the env vars from the build environment, causing build warnings and potential runtime failures.Added variables:
INKEEP_AGENTS_API_URLINKEEP_AGENTS_MANAGE_API_BYPASS_SECRETINKEEP_AGENTS_MANAGE_UI_PASSWORDPUBLIC_INKEEP_AGENTS_API_URLNANGO_SECRET_KEYGOOGLE_CLIENT_SECRETPUBLIC_GOOGLE_CLIENT_IDTRUSTED_ORIGINENABLE_AUTHZTest plan
missing from "turbo.json"warnings for these variablesMade with Cursor