Added unexpected error message to the player view#3
Merged
joethephish merged 2 commits intomasterfrom May 29, 2016
Merged
Conversation
Just simply shows the stderr message in the editor
| events.unexpectedExit(); | ||
| }); | ||
|
|
||
| ipc.on("play-story-unexpected-error", (event, error, fromSessionId) => { |
Collaborator
Author
There was a problem hiding this comment.
I decided to create a new message type but let me know if you prefer to change play-story-unexpected-exit instead
bjennings76
added a commit
to bjennings76/inky
that referenced
this pull request
Feb 1, 2018
- Added a generic 'escapes' section that should capture most escape locations - Separated out 'gather' into a push/pop group - Added escapes, comments, and a 'logicLineInsert' type into push area of 'gather' - Added support for comments after VARs - Removed custom markup for tag escapes since it's now build-in at a higher level - Added push section to tags to support post-tag comments - Added escapes to all statements in general
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just simply shows the stderr message in the editor
fixes #2