Feature/jax abstract builder class #433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DriesSmit
reviewed
Feb 24, 2022
DriesSmit
reviewed
Feb 24, 2022
Contributor
DriesSmit
left a comment
There was a problem hiding this comment.
I really like this setup! Really cool work, thanks @arnupretorius 🔥 🔥 Just see my comment.
DriesSmit
previously approved these changes
Feb 24, 2022
DriesSmit
approved these changes
Mar 1, 2022
AsadJeewa
approved these changes
Mar 1, 2022
Contributor
AsadJeewa
left a comment
There was a problem hiding this comment.
Looks good. Difficult to review PRs with abstract classes but all seems in order and keen to see concrete implementations. Thanks
sash-a
reviewed
Mar 1, 2022
Contributor
KaleabTessera
left a comment
There was a problem hiding this comment.
Thanks @arnupretorius , just some comments/clarifications!
KaleabTessera
approved these changes
Mar 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Abstract builder class for jax-based Mava systems.
Why?
To inform the builder for Jax systems through inheritance.
How?
Create class with the required functions, including building a data and parameter server, executor and trainer process.
Extra
@DriesSmit I decided to remove the evaluator as a separate build function since I think we can just use the executor and specify that it is an evaluator process using
executor_id="evaluator". Let me know what you think 🙂closes #429