Bugfix: Fixed conventional commit pre-commit hook not running. #395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmorris44
previously approved these changes
Feb 7, 2022
arnupretorius
previously approved these changes
Feb 7, 2022
Collaborator
arnupretorius
left a comment
There was a problem hiding this comment.
Thanks @KaleabTessera 👍
AsadJeewa
reviewed
Feb 7, 2022
Contributor
AsadJeewa
left a comment
There was a problem hiding this comment.
Testing on my side locally. I think we need to be explicit on the commit stage for each hook
AsadJeewa
suggested changes
Feb 7, 2022
Contributor
AsadJeewa
left a comment
There was a problem hiding this comment.
see comments for changes and also update (https://github.com/instadeepai/Mava/blob/develop/CONTRIBUTING.md)
1a8f441
Contributor
|
I have updated with the changes that I requested above for review |
Contributor
Author
|
Thanks @AsadJeewa , the changes look correct 👍 |
AsadJeewa
approved these changes
Feb 7, 2022
arnupretorius
approved these changes
Feb 7, 2022
Collaborator
arnupretorius
left a comment
There was a problem hiding this comment.
Thanks @KaleabTessera and @AsadJeewa 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix conventional commit pre-commit hook.
Why?
Invalid commit messages should be blocked at a commit level.
How?
Extra
Closes #394 .