Skip to content

Conversation

@surana01
Copy link
Contributor

Implement a Generator class for the Knapsack environment which is responsible for generating the Knapsack instances. This will include the following additions:

  • A generator.py script added to the knapsack folder which implements an abstract class Generator and a RandomGenerator to create a random uniform Knapsack instance.
  • A generator_test.py script to test the generator.
  • Modifications to env.py to include the generator in the init method and changes to conftest.py to include a DummyGenerator for testing purposes.

@surana01 surana01 added the enhancement New feature or request label May 18, 2023
@surana01 surana01 requested a review from clement-bonnet May 18, 2023 15:09
@surana01 surana01 self-assigned this May 18, 2023
clement-bonnet
clement-bonnet previously approved these changes May 26, 2023
Copy link
Contributor

@clement-bonnet clement-bonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Co-authored-by: Clément Bonnet <56230714+clement-bonnet@users.noreply.github.com>
@clement-bonnet clement-bonnet merged commit 87ebb7f into instadeepai:main May 26, 2023
@surana01 surana01 deleted the kp-generator branch May 26, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants