feat: implement the sliding tile puzzle env #189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sash-a
requested changes
Jul 24, 2023
Collaborator
sash-a
left a comment
There was a problem hiding this comment.
This looks really great! Couple minor changes and we got to wait and see how well it performs 🔥
clement-bonnet
suggested changes
Jul 30, 2023
Contributor
clement-bonnet
left a comment
There was a problem hiding this comment.
Thank you for the PR! Left a few comments on a first review :)
|
What's the status of this PR? Anything I could help with? |
sash-a
previously approved these changes
Jan 11, 2024
Collaborator
sash-a
left a comment
There was a problem hiding this comment.
Sorry this took so long, but awesome work @ElshadaiK I think it's pretty much ready just some minor comments from my side
Contributor
clement-bonnet
left a comment
There was a problem hiding this comment.
LGTM overall, still investigating why training doesn't work.
0284549 to
72af3fe
Compare
sash-a
requested changes
Mar 13, 2024
Collaborator
sash-a
left a comment
There was a problem hiding this comment.
Just some small things we need to add here. Also need to add this mkdocs.yaml and add the gif
Co-authored-by: Sasha <reallysasha@gmail.com>
Co-authored-by: Sasha <reallysasha@gmail.com>
Co-authored-by: Sasha <reallysasha@gmail.com>
Co-authored-by: Clément Bonnet <56230714+clement-bonnet@users.noreply.github.com>
Co-authored-by: Sasha <reallysasha@gmail.com>
Co-authored-by: Sasha <reallysasha@gmail.com>
Co-authored-by: Sasha <reallysasha@gmail.com>
5acc203 to
00d6980
Compare
Co-authored-by: Sasha <reallysasha@gmail.com>
clement-bonnet
previously approved these changes
Mar 13, 2024
clement-bonnet
previously approved these changes
Mar 13, 2024
sash-a
previously approved these changes
Mar 13, 2024
clement-bonnet
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Implements the full
SlidingTilePuzzleenvironment with actor-critic and random networks as well as documentation.Notes:
Gifs are still to be updated. Training of an a2c agent is ongoing