feat: upgrade gym wrapper to gymnasium #264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WiemKhlifi
requested changes
Nov 21, 2024
Contributor
WiemKhlifi
left a comment
There was a problem hiding this comment.
Thanks @sash-a! I have few comments the rest looks good and functional 🔥
- Can we please update the readme link for openai gym in wrappers.md (Jumanji To Gym section) to gymnasium?
- Also update the readme example:
env = jumanji.make("Snake-v1")
....
obs, extras = gym_env.reset()
...
obs, reward, terminated, truncated, info = gym_env.step(action)- Same fix for the name of env in the other sections.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop support for gym and update the gym wrapper to the gymnasium API
Closes #180