Skip to content

ci: use org variable for AWS EC2 AMI in E2E CI jobs#302

Merged
mergify[bot] merged 1 commit into
instructlab:mainfrom
nathan-weinberg:ami
Oct 25, 2024
Merged

ci: use org variable for AWS EC2 AMI in E2E CI jobs#302
mergify[bot] merged 1 commit into
instructlab:mainfrom
nathan-weinberg:ami

Conversation

@nathan-weinberg

@nathan-weinberg nathan-weinberg commented Oct 24, 2024

Copy link
Copy Markdown
Member

This will allow us to do the following:

  1. Keep the AMI consistent across all of InstructLab
  2. Allow for updating the AMI without having to make a code change

@nathan-weinberg
ci: use org variable for AWS EC2 AMI in E2E CI jobs
391a9dc 
Signed-off-by: Nathan Weinberg <nweinber@redhat.com>
@nathan-weinberg nathan-weinberg requested review from a team, danmcp and n1hility October 24, 2024 16:59
@mergify mergify Bot added CI/CD Affects CI/CD configuration ci-failure labels Oct 24, 2024
@mergify mergify Bot added one-approval and removed ci-failure labels Oct 24, 2024
@nathan-weinberg nathan-weinberg removed the request for review from n1hility October 25, 2024 14:35
@mergify mergify Bot removed the one-approval label Oct 25, 2024
@mergify mergify Bot merged commit b54f32e into instructlab:main Oct 25, 2024
@nathan-weinberg nathan-weinberg deleted the ami branch October 25, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Maxusmusti Maxusmusti Maxusmusti approved these changes

+1 more reviewer

@danmcp danmcp danmcp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CI/CD Affects CI/CD configuration

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nathan-weinberg @danmcp @Maxusmusti