Documentation: Added CHANGELOG.md#315
Merged
Merged
Conversation
d0d7a41 to
72b9fa7
Compare
nathan-weinberg
approved these changes
Nov 1, 2024
Contributor
|
@Lo-Mein You'll need to address the linting errors for this PR to be able to merge: https://github.com/instructlab/training/actions/runs/11616705508/job/32390208095?pr=315 |
Signed-off-by: Lo-Mein <ryanlo5102000@gmail.com>
Signed-off-by: Lo-Mein <ryanlo5102000@gmail.com>
8c3dffb to
d18e572
Compare
mingxzhao
approved these changes
Nov 5, 2024
Member
|
Can you squash commits please @Lo-Mein? |
Member
|
@JamesKunstle @Maxusmusti Could you two please review this as well to ensure this isn't missing anything? |
Contributor
|
@RobotSail since this is a commit heading dump I don't think this misses anything. Going forward I'd like to switch from doing commit header changelogs and use hand-written changelogs when necessary, but this is an appreciated contribution! |
JamesKunstle
approved these changes
Nov 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a
CHANGELOG.mdfile to maintain a clear history of all changes, organized by version and type of change.Resolves issue #209
Signed-off-by: Lo-Mein ryanlo5102000@gmail.com