Skip to content

Update Dependencies to Move DeepSpeed to CUDA Extras#350

Merged
mergify[bot] merged 2 commits intomainfrom
deepspeed-move
Nov 15, 2024
Merged

Update Dependencies to Move DeepSpeed to CUDA Extras#350
mergify[bot] merged 2 commits intomainfrom
deepspeed-move

Conversation

@Maxusmusti
Copy link
Copy Markdown
Collaborator

Moving DeepSpeed requirement into CUDA extras, and making sure package installation is not required OOTB.

Signed-off-by: Mustafa Eyceoz <meyceoz@redhat.com>
@mergify mergify bot added the dependencies Pull requests that update a dependency file label Nov 15, 2024
@Maxusmusti Maxusmusti self-assigned this Nov 15, 2024
@Maxusmusti
Copy link
Copy Markdown
Collaborator Author

Tested that pip install instructlab-training -> pip install instructlab-training[cuda] path still works as expected, and that when DeepSpeed is not installed, default FSDP training path still works as expected.

Signed-off-by: Mustafa Eyceoz <meyceoz@redhat.com>
@Maxusmusti
Copy link
Copy Markdown
Collaborator Author

NOTE: Also capping Accelerate for now, as the recently released 1.1.x includes breaking changes that need to be resolved before it can be updated.

@mergify mergify bot added the one-approval label Nov 15, 2024
Copy link
Copy Markdown
Member

@RobotSail RobotSail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's Get This Money!!

@mergify mergify bot removed the one-approval label Nov 15, 2024
@mergify mergify bot merged commit e19c744 into main Nov 15, 2024
@mergify mergify bot deleted the deepspeed-move branch November 15, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants