fix: --keep_last_checkpoint_only does not accept any values#397
Merged
Conversation
We should not assign a value to this parameter, as it takes no values. Signed-off-by: Courtney Pacheco <6019922+courtneypacheco@users.noreply.github.com>
|
E2E (NVIDIA L40S x4) workflow launched on this PR: View run |
bbrowning
approved these changes
Jan 16, 2025
bbrowning
left a comment
Contributor
There was a problem hiding this comment.
This fix looks good to me based on the linked issue, error thrown, and adjusting it to use the flag as booleans are intended instead of passing explicit values to the boolean flag.
RobotSail
approved these changes
Jan 16, 2025
|
e2e workflow succeeded on this PR: View run, congrats! |
nathan-weinberg
approved these changes
Jan 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #396
We should not assign a value to this parameter, as it takes no values.