Generic notebook support#432
Merged
mergify[bot] merged 3 commits intoMar 25, 2025
Merged
Conversation
Signed-off-by: Mustafa Eyceoz <meyceoz@redhat.com>
Signed-off-by: Mustafa Eyceoz <meyceoz@redhat.com>
RobotSail
approved these changes
Mar 24, 2025
RobotSail
left a comment
Member
There was a problem hiding this comment.
One question but otherwise LGTM
| "GraniteForCausalLM", | ||
| ], f"Model class name: {model.__class__.__name__} is not supported." | ||
| assert ( | ||
| "ForCausalLM" in model.__class__.__name__ |
Member
There was a problem hiding this comment.
I think we had a reason for this restriction, but I think it will be fine to lift this and revisit if it ever reappears.
| "Model path does not appear to be a directory. Please make sure that you're passing a Hugging Face Transformers compatible directory checkpoint." | ||
| ) | ||
| else: | ||
| elif not len(train_args.model_path.split("/")) == 2: |
Collaborator
Author
There was a problem hiding this comment.
Updated error message to make expected input more clear
Signed-off-by: Mustafa Eyceoz <meyceoz@redhat.com>
aldopareja
approved these changes
Mar 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes logging to work in notebook environments, and also removes the existing file path barrier for huggingface models, as a follow-up to @abhi1092's PR #416
Also now accepts any CausalLM, rather than the previous hard-coded list.