Skip to content

fix: wait for medium e2e to finish and pass#627

Closed
cdoern wants to merge 1 commit into
mainfrom
wait-for-e2e
Closed

fix: wait for medium e2e to finish and pass#627
cdoern wants to merge 1 commit into
mainfrom
wait-for-e2e

Conversation

@cdoern

@cdoern cdoern commented Jun 25, 2025

Copy link
Copy Markdown
Collaborator

the medium e2e job should:

  1. be blocking
  2. use pull_request_target properly to gate access to secrets from untested code

@mergify

mergify Bot commented Jun 25, 2025

Copy link
Copy Markdown
Contributor

⚠️ The sha of the head commit of this PR conflicts with #606. Mergify cannot evaluate rules on this PR. ⚠️

@mergify mergify Bot added the CI/CD Affects CI/CD configuration label Jun 25, 2025
Signed-off-by: Charlie Doern <cdoern@redhat.com>
@booxter

booxter commented Jun 25, 2025

Copy link
Copy Markdown
Contributor

This seems wrong since the change doesn't get rid of secrets read in e2e step. Unless we can fetch models and such without tokens, we cannot have the job as pull_request_target.

@mergify mergify Bot added the ci-failure label Jun 25, 2025
@cdoern

cdoern commented Jun 27, 2025

Copy link
Copy Markdown
Collaborator Author

I am still working on this, comparing it to the one in instructlab/instructlab. In the meantime we can consider disabling this workflow on PRs if there is one we need to merge.

@github-actions

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had activity within 90 days. It will be automatically closed if no further activity occurs within 30 days.

@github-actions github-actions Bot added the stale label Sep 26, 2025
@mergify

mergify Bot commented Sep 26, 2025

Copy link
Copy Markdown
Contributor

This pull request has merge conflicts that must be resolved before it can be
merged. @cdoern please rebase it. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify Bot added the needs-rebase label Sep 26, 2025
@github-actions github-actions Bot removed the stale label Sep 27, 2025
@github-actions

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had activity within 90 days. It will be automatically closed if no further activity occurs within 30 days.

@github-actions github-actions Bot added the stale label Dec 26, 2025
@github-actions

Copy link
Copy Markdown

This pull request has been automatically closed due to inactivity. Please feel free to reopen if you intend to continue working on it!

@github-actions github-actions Bot closed this Jan 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants