This repository was archived by the owner on Jul 25, 2024. It is now read-only.
update nonce in ehsm_kms_service #288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syan10
reviewed
Jul 28, 2023
| } | ||
| const { | ||
| appid, | ||
| timestamp: nonce, |
Contributor
There was a problem hiding this comment.
add a comment to describe nonce is a optional param
3e15936 to
a34c794
Compare
yang8621
approved these changes
Aug 2, 2023
syan10
approved these changes
Aug 3, 2023
Contributor
|
is undefined checked? |
no longer use the timestamp as nonce, since it will have concurrency access issues, even for different requests. now, the nonce is optional which max length is 64 bytes, the caller can decide whether to pass it with the request data. Signed-off-by: lisiteng <sitengx.li@intel.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
no longer use the timestamp as nonce, since it will have concurrency access issues, even for different requests.
now, the nonce is optional which max length is 64 bytes, the caller can decide whether to pass it with the request data.
Signed-off-by: lisiteng sitengx.li@intel.com