migrate parallel_prefix to new branch #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkorbel1
reviewed
Feb 6, 2024
lib/src/component_config/components/config_parallel_prefix_adder.dart
Outdated
Show resolved
Hide resolved
mkorbel1
reviewed
Feb 6, 2024
lib/src/component_config/components/config_parallel_prefix_adder.dart
Outdated
Show resolved
Hide resolved
mkorbel1
reviewed
Feb 6, 2024
| sdk: '>=3.0.0 <4.0.0' | ||
|
|
||
| dependencies: | ||
| collection: ^1.18.0 |
Contributor
There was a problem hiding this comment.
Self-note: pending open-source dependency review (already submitted, awaiting approval)
mkorbel1
reviewed
Feb 6, 2024
mkorbel1
approved these changes
Feb 6, 2024
Contributor
mkorbel1
left a comment
There was a problem hiding this comment.
Looks good to me! Nice!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & Motivation
Parallel prefix trees implementing adders, priorityencoder, incrementer, decrementer, and orscan
Related Issue(s)
#12
Testing
Tests included for each component with each flavor of prefix tree.
Backwards-compatibility
No.
Documentation
Yes. The new components have updated documentation, and an attempt at making the configurator work with the adder.