-
Notifications
You must be signed in to change notification settings - Fork 172
feat(form): rename creators to authors and help text #3198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
It would be nice to have feedback on the help text message, to make sure that is clear. |
8ed53fe to
4eacf53
Compare
|
Perhaps something like:
cc @slint Once this goes online we need to update user documentation on Zenodo |
|
Contributors may be included in the citation in the case of editors and certain content types (book chapters, etc.) |
I don't think we've implemented any of that serialization (though we should). But because we have roles for creators (unlike DataCite), we can add editors in the creators field and keep the rule that the field determines whether someone shows up in the citation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some small things, otherwise looks good from a technical perspective :)
invenio_app_rdm/records_ui/templates/semantic-ui/invenio_app_rdm/records/detail.html
Show resolved
Hide resolved
invenio_app_rdm/records_ui/templates/semantic-ui/invenio_app_rdm/records/detail.html
Outdated
Show resolved
Hide resolved
4eacf53 to
9b8a0e7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I'm going to be possibly be controversial and raise the question of whether authors and contributors should be next to each other on the deposit form. Authors is at the end of the required part of the form, and putting them together makes the connection a lot clearer.
This is how we've implemented it:
invenio_app_rdm/theme/assets/semantic-ui/js/invenio_app_rdm/deposit/RDMDepositForm.js
Outdated
Show resolved
Hide resolved
| <CreatibutorsField | ||
| addButtonLabel={i18next.t("Add contributor")} | ||
| addButtonHelpText={i18next.t( | ||
| "Contributors (compared to authors) are not included in citations, but are shown on the record page." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "Contributors (compared to authors) are not included in citations, but are shown on the record page." | |
| "Contributors are not included in the citation, but are shown on the record page." |
I'm not sure the compared to authors bit is really necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tmorrell encouraged me to also say something controversial, not about the specific changes, but the broader topic of creators and contributors. Today I worked on better implementing contributor roles in my InvenioRDM instance based on the needs of the ropensi community blog (https://doi.org/10.59350/510pg-zzf58). As I said before, the terminology author/creator/contributor is messy and for example different between DataCite/Crossref/ORCID/DublinCore/Schema.org and the distinction based on who is listed in a citation is also not always clear. In addition, and more important for InvenioRDM, there is an increasing need to document broader contributions (in the case of ropensci blog for example editor and translator), but also for example reviewer or thesis supervisor plus the various roles in the CrediT taxonomy.
My suggestion is to deploy the proposed form changes (with the details TBD as currently discussed), and then look into bigger changes in the coming months - as a feature for the v14.0 release. Basically consolidating everything around the concept "contributor" with a list of possible roles for each contributor. For DOI registration with DataCite (and Crossref) this must be mapped to their schemata, but this was straightforward when I did this in the commonmeta library.
What we would gain is not only a simpler submission form, and better alignment with other metadata schemata but more flexibility of what contributions we want to include in InvenioRDM metadata.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The various roles defined in the citation-style-language (and therefore appearing in at least some citations) are defined here: https://docs.citationstyles.org/en/stable/specification.html?highlight=translator#name-variables Some are not relevant for scholarly content, but many of them could be useful in InvenioRDM record metadata.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, I propose to bring up the topic as a GitHub Discussion and present it in a telecon, to collect feedback from everyone.
* rename the Creators field to Authors/Creators * add help text under Authors and Contributors to explain the difference * closes inveniosoftware#3197
9b8a0e7 to
832a644
Compare
Requires: inveniosoftware/invenio-rdm-records#2176