Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Sep 18, 2025

The installation script was displaying multiple IP addresses in the final success message when both ethernet and WiFi interfaces were active. Users reported seeing misleading messages like:

==========================================================================

    ioBroker was installed successfully
    Open http://192.168.2.13 192.168.2.167:8081 in a browser and start configuring!

==========================================================================

Instead of the expected single IP:

==========================================================================

    ioBroker was installed successfully
    Open http://192.168.2.13:8081 in a browser and start configuring!

==========================================================================

The issue occurred in the detect_ip_address() function in installer_library.sh where edge cases could cause the head -1 command to not properly limit the output to a single IP address, resulting in multiple IPs being included in the final message.

Solution:
Enhanced the detect_ip_address() function with an additional robust filtering step that ensures only one IP address is returned by removing potential newlines and extra whitespace:

# Ensure we return only the first IP address, removing any potential newlines or extra content
IP=$(echo "$IP" | head -1 | tr -d '\n\r' | awk '{print $1}')

Changes:

  • Updated detect_ip_address() function in installer_library.sh with additional IP filtering
  • Bumped installer version to 2025-09-18
  • Added changelog entry documenting the fix
  • Rebuilt distribution scripts to include the fix

The fix is minimal and maintains backward compatibility while ensuring users always see a clean, single IP address in the final installation message regardless of their network configuration.

Fixes #484.


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: GermanBluefox <4582016+GermanBluefox@users.noreply.github.com>
Copilot AI changed the title [WIP] install script final message missleading when eth0 and wlan0 enabled Fix IP detection to show only one IP in final installation message Sep 18, 2025
Copilot AI requested a review from GermanBluefox September 18, 2025 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

install script final message missleading when eth0 and wlan0 enabled

2 participants