Fix IP detection to show only one IP in final installation message #652
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The installation script was displaying multiple IP addresses in the final success message when both ethernet and WiFi interfaces were active. Users reported seeing misleading messages like:
Instead of the expected single IP:
The issue occurred in the
detect_ip_address()function ininstaller_library.shwhere edge cases could cause thehead -1command to not properly limit the output to a single IP address, resulting in multiple IPs being included in the final message.Solution:
Enhanced the
detect_ip_address()function with an additional robust filtering step that ensures only one IP address is returned by removing potential newlines and extra whitespace:Changes:
detect_ip_address()function ininstaller_library.shwith additional IP filtering2025-09-18The fix is minimal and maintains backward compatibility while ensuring users always see a clean, single IP address in the final installation message regardless of their network configuration.
Fixes #484.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.