Repository navigation
Google images links that use udm=imgs instead of udm=2 are not blocked #1086
Closed
GrenatDuene
started this conversation in
Bugs
Replies: 1 comment
|
Thanks for the report! This has been fixed in ublacklist/builtin#127. The built-in SERPINFO is updated automatically, but you can also update it right away from the options page. |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Bug Description
Sometimes (maybe all the time from now on?), google uses the tag udm=imgs instead of udm=2 to signify that the user clicked on the 'images tab' , thus the page is not recognized by ublacklist becaues it is looking only for udm=2
(oh, i just found out that this applies also to video tabs where google uses udm=vids instead of udm=7, and maybe others though i'm not sure if ublacklist is supposed to work in the news tab or short videos because i don't use them)
Steps to Reproduce
Make any google search then click on the images tab, here is an example link where the issue happens:
https://www.google.com/search?udm=imgs&q=small+cable+protector+car+-ev
Expected Behavior
ublacklist should recognise that it needs to activate on this page and start blocking results.
Actual Behavior
Instead, ublacklist does nothing at all because it doesn't recognise the page.
I am pretty sure that this is the reason, because if i just modify the url by hand to replace 'imgs' with '2', like this:
https://www.google.com/search?udm=2&q=small+cable+protector+car+-ev
Then click enter, ublacklist works perfectly again.
( if you have ublock origin turned on, you might need to 1°) paste the url and wait until the page has fully loaded, 2°) click in the search field, 3°) hit enter to relauch the search. (simply refreshing the page doesn't work))
Browser
Firefox 156.0
uBlacklist Version
10.0.4
Search Engine
Google.com
Additional Context
I really hope that i haven't missed anything and that others can reproduce it, because i can't see what else could be causing it in my setup. Thank you for your help !
Also, this page has a list of all the udm codes in case you need it for reference !
Checklist
All reactions