advertise multiple addresses over mdns #1165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@whyrusleeping any reason they're only advertising one address? they should be advertising all of them.
given how messy networking is, i'm sure there's some case where this isn't true. probably small. |
Member
Author
|
Yeah, for some reason it never occurred to me that I should put more than a single address on that message. even though the message supports multiple ip addresses... |
Member
|
LGTM. (we should fix the tests) |
jbenet
added a commit
that referenced
this pull request
May 1, 2015
advertise multiple addresses over mdns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nodes were failing to connect to eachother on my LAN because they advertised their loopback address instead of their lan local address. just skip loopback addresses because any node on the same machine can connect via any of the interface addresses just the same.