Skip to content

Conversation

@bjacob
Copy link
Collaborator

@bjacob bjacob commented Dec 18, 2025

Integrate llvm/llvm-project@1c023cb

This folds Lukas' commits from #22921. Thanks!

Additional local change: adding f16<->f64 conversions and f64 fma to libdevice as these are now required by lowerings of f16 multiply-add to targets without native f16 support (typically CPU targets).

  • The symptom that this is fixing, is unresolved symbol errors at linking.
  • The regressing upstream PR is fix llvm.fma.f16 double rounding issue when there is no native support llvm/llvm-project#171904.
    • Rationale given there: it's necessary to go to f64 to implement a perfectly accurate f16 multiply-add without observable double-rounding.
  • We don't need to worry too much about the performance here: by definition, this code only happens when we use a data type that is not natively supported in hardware, so users who care about performance should not be on such a path anyway. This preexisting rationale is why the libdevice implementation of f16 conversions favors simplicity over performance.

Existing local reverts carried forward:

@bjacob bjacob force-pushed the integrates/llvm-20251218 branch 2 times, most recently from 89af862 to bc92f67 Compare December 19, 2025 16:39
bjacob and others added 3 commits December 19, 2025 16:48
…SymbolOpInterface to implement operateOnSymbol in test-symbol-uses pass (#172675) (lonely eagle on 2025-12-18 20:58:30 +0800) (14 of 15)

Signed-off-by: Benoit Jacob <jacob.benoit.1@gmail.com>
Integrate upstream changes to the `dropUnitDims` API into the `FoldUnitExtentDims` pass.

The behavior remains the same for now.

Signed-off-by: Lukas Sommer <lukas.sommer@amd.com>
Signed-off-by: Lukas Sommer <lukas.sommer@amd.com>
@bjacob bjacob force-pushed the integrates/llvm-20251218 branch from bc92f67 to 4a4a3bf Compare December 19, 2025 16:49
Signed-off-by: Benoit Jacob <jacob.benoit.1@gmail.com>
@bjacob bjacob force-pushed the integrates/llvm-20251218 branch from 4a4a3bf to 054b836 Compare December 19, 2025 16:50
@bjacob bjacob marked this pull request as ready for review December 19, 2025 17:03
Signed-off-by: Benoit Jacob <jacob.benoit.1@gmail.com>
@bjacob bjacob merged commit 09843a8 into iree-org:main Dec 19, 2025
51 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants