Skip to content

Add mount! macro to simplify the construction of Mount objects #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jpmartin2 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add mount! macro to simplify the construction of Mount objects #79

jpmartin2 wants to merge 2 commits into from

Conversation

@jpmartin2
Copy link

@jpmartin2 jpmartin2 commented Mar 28, 2016

I've been doing some work on a simple web application in rust using iron, and while creating the routes for it, I noticed that the router crate had a convenient macro to create the router handler, but mount doesn't. I wanted to be able to write

let handler = mount! {
    "/static" => Static::new(Path::new("path/to/static/files")),
    "/" => router! {
        get "/" => some_other_hanler,
        ...
    },
};

This PR adds the mount! macro so you can write that instead of

let router = router {
    get "/" => some_other_handler,
   ...
};

let mut handler = Mount::new();
handler.mount("/static", Static::new(Path::new("path/to/static/files"));
handler.mount("/", router);

@joshmarlow
Copy link

joshmarlow commented Feb 19, 2017

@iron-bot any thoughts on this?

untitaker
untitaker reviewed Feb 19, 2017
View reviewed changes
src/macros.rs
/// ```ignore
/// let mut mount = Mount::new();
/// mount.mount("/", index);
/// mount.mount("/:query", queryHandler);
Copy link
Member

@untitaker untitaker Feb 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this example suggests that mount can deal with variables in paths when it only matches by prefix. Also your macro example says router!, not mount!.

@turnage turnage mentioned this pull request Jul 2, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@untitaker untitaker untitaker left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jpmartin2 @joshmarlow @untitaker