Ci improvements #3677
Ci improvements #3677
Conversation
|
@codex review |
|
To use Codex here, create a Codex account and connect to github. |
There was a problem hiding this comment.
Pull request overview
This PR implements several CI/CD workflow improvements to address failing jobs and enhance reliability. The changes focus on increasing robustness through retry logic, fixing resource constraints, correcting path configurations, and improving CVE scan reliability.
Key changes:
- Added retry logic for test execution to handle transient failures
- Fixed resource constraints by freeing disk space and reducing macOS test matrix
- Corrected YARPGEN workflow path configuration
- Improved CVE scanning reliability by switching to more stable data sources
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/fail_db.txt | Documents known Windows test failures for short vector selection functions |
| .github/workflows/yarpgen.yml | Fixes YARPGEN path setup to point to correct script and build directories |
| .github/workflows/scripts/check-dll-injection.py | Updates copyright year and suppresses ispc.exe output |
| .github/workflows/reusable.ispc.test.yml | Adds retry logic for test steps and fixes output variable usage |
| .github/workflows/release-pipeline.yml | Adds disk space cleanup step to prevent out-of-space failures |
| .github/workflows/ispc-ci.yml | Reduces macOS/aarch64 test matrix to prevent timeouts |
| .github/workflows/cve-bin.yml | Improves CVE scan reliability with timeout and stable data sources |
| .github/workflows/cve-bin-releases.yml | Improves CVE scan reliability with timeout and stable data sources |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@codex review |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
af5dd19 to
76497ec
Compare
76497ec to
59364d0
Compare
59364d0 to
cb6b2ff
Compare
Description
A bunch of CI improvements fixing current failing jobs.
jlumbroso/free-disk-spacein therelease-pipeline.ymlworkflow to help prevent job failures due to insufficient disk space.cve-bin-releases.ymlandcve-bin.ymlto use thejson-nvdsource, disable unreliable sources, and set a timeout to improve reliability and avoid flaky runs.reusable.ispc.test.ymlusingnick-fields/retry, increasing robustness against transient failures for both Linux/macOS and Windows jobs.ispc-ci.ymlto avoid timeout.fail_db.txt.check-dll-injection.pyand suppressed output fromispc.exeruns to focus on DLL loading behavior.yarpgen.ymlto correctly add YARPGEN scripts and build directories to the environment path.reusable.ispc.test.ymlto useGITHUB_OUTPUTinstead ofGITHUB_ENV, following GitHub Actions best practices for output management.Related Issue
Checklist
clang-format(e.g.,clang-format -i src/ispc.cpp)