Skip to content

Revert back to use serde_yaml again #1112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
j178 merged 1 commit into from
Nov 18, 2025
Merged

Revert back to use serde_yaml again #1112

j178 merged 1 commit into from
Nov 18, 2025

Conversation

@j178
Copy link
Owner

@j178 j178 commented Nov 18, 2025 •
edited
Loading

It's a good experiment anyway, I'll keep looking at serde-saphyr.

Closes #1111

@j178 j178 added the bug Something isn't working label Nov 18, 2025
@j178 j178 changed the title Revert back to serde_yaml again Revert back to use serde_yaml again Nov 18, 2025
@codecov
Copy link

codecov bot commented Nov 18, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 32.55814% with 58 lines in your changes missing coverage. Please review.
✅ Project coverage is 26.97%. Comparing base (df5068a) to head (26e86aa).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/config.rs 17.14% 29 Missing ⚠️
src/yaml.rs 50.00% 22 Missing ⚠️
src/cli/auto_update.rs 0.00% 7 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (df5068a) and HEAD (26e86aa). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (df5068a) HEAD (26e86aa)
2 1
Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #1112       +/-   ##
===========================================
- Coverage   89.85%   26.97%   -62.88%     
===========================================
  Files          72       73        +1     
  Lines       13432    13471       +39     
===========================================
- Hits        12069     3634     -8435     
- Misses       1363     9837     +8474

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Nov 18, 2025

📦 Cargo Bloat Comparison

Binary size change: -1.81% (16.6 MiB → 16.3 MiB)

Expand for cargo-bloat output

Head Branch Results

 File  .text     Size          Crate Name
 0.6%   1.3% 101.3KiB          prek? <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
 0.6%   1.3%  97.4KiB           prek prek::builtin::pre_commit_hooks::Implemented::run::{{closure}}
 0.6%   1.2%  94.0KiB           prek prek::languages::<impl prek::config::Language>::run::{{closure}}
 0.3%   0.7%  54.6KiB           prek prek::archive::unpack::{{closure}}
 0.3%   0.6%  48.8KiB           prek prek::run::{{closure}}
 0.2%   0.5%  41.3KiB           prek prek::languages::<impl prek::config::Language>::install::{{closure}}
 0.2%   0.5%  39.1KiB          prek? <prek::cli::RunArgs as clap_builder::derive::Args>::augment_args
 0.2%   0.5%  37.3KiB regex_automata regex_automata::meta::strategy::new
 0.2%   0.4%  32.5KiB             h2 h2::proto::connection::Connection<T,P,B>::poll
 0.2%   0.4%  32.3KiB           prek prek::languages::node::installer::NodeInstaller::install::{{closure}}
 0.2%   0.4%  31.9KiB             h2 h2::proto::connection::DynConnection<B>::recv_frame
 0.2%   0.4%  31.5KiB           prek prek::workspace::Workspace::discover
 0.2%   0.4%  30.4KiB           prek prek::cli::run::run::run::{{closure}}
 0.2%   0.4%  27.6KiB           prek prek::identify::by_extension::{{closure}}
 0.2%   0.3%  25.5KiB     hyper_util hyper_util::client::legacy::client::Client<C,B>::connect_to::{{closure}}::{{closure}}::{{closure}}
 0.2%   0.3%  25.1KiB           prek prek::main
 0.1%   0.3%  24.9KiB     hyper_util hyper_util::client::legacy::client::Client<C,B>::send_request::{{closure}}
 0.1%   0.3%  24.7KiB           prek prek::hook::HookBuilder::build::{{closure}}
 0.1%   0.3%  24.2KiB           prek prek::languages::golang::installer::GoInstaller::install::{{closure}}
 0.1%   0.3%  23.9KiB          hyper hyper::proto::h1::dispatch::Dispatcher<D,Bs,I,T>::poll_loop
40.1%  87.9%   6.5MiB                And 10242 smaller methods. Use -n N to show more.
45.7% 100.0%   7.4MiB                .text section size, the file size is 16.3MiB

Base Branch Results

 File  .text     Size          Crate Name
 0.6%   1.3% 101.3KiB          prek? <prek::cli::Command as clap_builder::derive::Subcommand>::augment_subcommands
 0.6%   1.2%  97.7KiB           prek prek::builtin::pre_commit_hooks::Implemented::run::{{closure}}
 0.6%   1.2%  94.7KiB           prek prek::languages::<impl prek::config::Language>::run::{{closure}}
 0.3%   0.7%  54.6KiB           prek prek::archive::unpack::{{closure}}
 0.3%   0.6%  48.8KiB           prek prek::run::{{closure}}
 0.2%   0.5%  41.3KiB           prek prek::languages::<impl prek::config::Language>::install::{{closure}}
 0.2%   0.5%  39.1KiB          prek? <prek::cli::RunArgs as clap_builder::derive::Args>::augment_args
 0.2%   0.5%  37.3KiB regex_automata regex_automata::meta::strategy::new
 0.2%   0.4%  32.5KiB             h2 h2::proto::connection::Connection<T,P,B>::poll
 0.2%   0.4%  32.3KiB           prek prek::languages::node::installer::NodeInstaller::install::{{closure}}
 0.2%   0.4%  31.9KiB             h2 h2::proto::connection::DynConnection<B>::recv_frame
 0.2%   0.4%  31.8KiB           prek prek::workspace::Workspace::discover
 0.2%   0.4%  30.5KiB           prek prek::cli::run::run::run::{{closure}}
 0.2%   0.3%  27.6KiB           prek prek::identify::by_extension::{{closure}}
 0.1%   0.3%  25.5KiB     hyper_util hyper_util::client::legacy::client::Client<C,B>::connect_to::{{closure}}::{{closure}}::{{closure}}
 0.1%   0.3%  25.3KiB           prek prek::hook::HookBuilder::build::{{closure}}
 0.1%   0.3%  25.1KiB           prek prek::main
 0.1%   0.3%  24.9KiB     hyper_util hyper_util::client::legacy::client::Client<C,B>::send_request::{{closure}}
 0.1%   0.3%  24.6KiB           prek prek::cli::auto_update::auto_update::{{closure}}
 0.1%   0.3%  24.2KiB           prek prek::languages::golang::installer::GoInstaller::install::{{closure}}
41.0%  88.3%   6.8MiB                And 10426 smaller methods. Use -n N to show more.
46.4% 100.0%   7.7MiB                .text section size, the file size is 16.6MiB

@j178 j178 merged commit 683ad1f into master Nov 18, 2025
21 checks passed
@j178 j178 deleted the serde-yaml-again branch November 18, 2025 14:46
@BrewTestBot BrewTestBot mentioned this pull request Nov 18, 2025
Merged
@hugovk hugovk mentioned this pull request Nov 21, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

error: Failed to parse .pre-commit-config.yaml

2 participants

@j178