Skip to content

remove unneeded check #2658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nblock merged 3 commits into from
Jul 4, 2025
Merged

remove unneeded check #2658

nblock merged 3 commits into from
Jul 4, 2025

Conversation

@stavros-k
Copy link
Contributor

@stavros-k stavros-k commented Jun 25, 2025 •
edited
Loading

  • have read the CONTRIBUTING.md file
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

There is no need to check if parent is set here, we only care if the specific key is set.
Before this change, only by applying env HEADSCALE_NOISE_PRIVATE_KEY_PATH=/some/path would trigger this error.
I had to also set env HEADSCALE_NOISE=true to bypass it.

@stavros-k stavros-k mentioned this pull request Jun 25, 2025
Merged
kradalby
kradalby approved these changes Jul 4, 2025
View reviewed changes
Copy link
Collaborator

@kradalby kradalby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find, thanks

@ghost
Copy link

ghost commented Jul 4, 2025 •
edited by ghost
Loading

Pull Request Revisions

RevisionDescription
r2
Remove redundant noise config checkSimplified noise configuration validation by removing redundant !viper.IsSet("noise") check in config validation
r1
Remove redundant noise config checkSimplified noise configuration validation by removing unnecessary !viper.IsSet("noise") check in config validation
✅ AI review completed for r2
Help React with emojis to give feedback on AI-generated reviews:
  • 👍 means the feedback was helpful and actionable
  • 👎 means the feedback was incorrect or unhelpful
💬 Replying to feedback with a comment helps us improve the system. Your input also contributes to shaping future interactions with the AI reviewer.

We'd love to hear from you—reach out anytime at team@review.ai.

@nblock nblock enabled auto-merge (squash) July 4, 2025 13:27
@nblock nblock merged commit 855c48a into juanfont:main Jul 4, 2025
144 of 150 checks passed
@stavros-k stavros-k deleted the noise-check branch July 4, 2025 16:06
@chenrui333 chenrui333 mentioned this pull request Oct 27, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kradalby kradalby kradalby approved these changes

@juanfont juanfont Awaiting requested review from juanfont juanfont is a code owner

@ohdearaugustin ohdearaugustin Awaiting requested review from ohdearaugustin ohdearaugustin is a code owner

@nblock nblock Awaiting requested review from nblock nblock is a code owner

+1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stavros-k @kradalby @nblock