remove unused ips from alloc ipset #2831
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kradalby
reviewed
Oct 31, 2025
kradalby
approved these changes
Nov 5, 2025
Collaborator
kradalby
left a comment
There was a problem hiding this comment.
Great, thank you. I'm going to hold this to next release to not add changes in patch releases.
Collaborator
|
adding a next changelog would be great. |
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With IPAllocationStrategy = "random" and strange environments (small VPN CIDR + k8s pods) users can run out of available IPs. So let's remove ips from ipset on DeleteNode.