hscontrol/oidc: fix ACL policy not applied to new OIDC nodes #2890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
950d7ac to
13546dc
Compare
2b66ec6 to
984121e
Compare
4 tasks
984121e to
e227dc2
Compare
3480f84 to
06f496b
Compare
Remove premature policy change notification after user creation in OIDC callback handler. This was causing a race condition where asynchronous policy updates interfered with node registration, resulting in new OIDC nodes receiving incomplete network maps. The policy manager is still updated synchronously during user creation, and handleRegistration now sends a single consolidated change notification after node registration completes. Add integration test to validate OIDC nodes immediately receive correct ACL policies and can see advertised routes without requiring a client restart. Regression introduced in 1553f0a (state: introduce state). Fixes juanfont#2888 Fixes juanfont#2896 Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
06f496b to
ed1fdc3
Compare
4fe5cbe
into
juanfont:kradalby/release-v0.27.2
186 of 189 checks passed
kradalby
added a commit
to kradalby/headscale
that referenced
this pull request
Dec 1, 2025
kradalby
added a commit
to kradalby/headscale
that referenced
this pull request
Dec 2, 2025
kradalby
added a commit
to kradalby/headscale
that referenced
this pull request
Dec 2, 2025
kradalby
added a commit
that referenced
this pull request
Dec 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove premature policy change notification after user creation in OIDC callback handler. This was causing a race condition where asynchronous policy updates interfered with node registration, resulting in new OIDC nodes receiving incomplete network maps.
The policy manager is still updated synchronously during user creation, and handleRegistration now sends a single consolidated change notification after node registration completes.
Add integration test to validate OIDC nodes immediately receive correct ACL policies and can see advertised routes without requiring a client restart.
Fixes #2888
claude was used in this PR.