Removes metrics code#425
Merged
Merged
Conversation
We no longer support metrics code, so we should remove the code. Moving it to dqlite would require understanding and maintaining code that has not full tested or integrated with romulus or omnibus is sometime. Fully understanding if all parts are correct would be challenging. If in the future we want to reuse parts, we can always look back in the history of the repo to bring back the parts that are required (if any).
Aflynn50
reviewed
Feb 21, 2024
Aflynn50
approved these changes
Feb 21, 2024
hmlanigan
approved these changes
Feb 21, 2024
| ### `metrics.yaml` | ||
|
|
||
| `metrics.yaml` represents an optional metrics gathering configuration yaml. For | ||
| more information about metrics, read up on [Metric collecting charms](https://discourse.juju.is/t/metric-collecting-charms/1125) |
Member
There was a problem hiding this comment.
We need to find where else in documentation this needs to be removed.
Member
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We no longer support metrics code, so we should remove the code. Moving it to dqlite would require understanding and maintaining code that has not full tested or integrated with romulus or omnibus is sometime. Fully understanding if all parts are correct would be challenging.
If in the future we want to reuse parts, we can always look back in the history of the repo to bring back the parts that are required (if any).