Optimize resizing dock panels (with an opt-out)#18877
Merged
Merged
Conversation
|
Thanks for making a pull request to jupyterlab! |
Member
Author
|
For final release we can toggle the default to |
Darshan808
approved these changes
May 19, 2026
Member
Darshan808
left a comment
There was a problem hiding this comment.
Feels much smoother now, Benchmarks looks compelling and code looks good too.
Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
This will allow us to get feedback on this change during the beta cycle, without having to commit to extended API surface in lumino yet.
Code changes
optimizeResizeShell settingOptimizedDockPanelSvgsubclass ofDockPanelSvgOptimizedDockPanelSvgin theLabShellUser-facing changes
Resizing is faster. This can be verified by running:
BENCHMARK_NUMBER_SAMPLES=20 jlpm test:benchmark --grep "Notebook Resize"To recreate table above
Before
Screencast.From.2026-04-21.15-21-43.webm
After
Screencast.From.2026-04-21.15-11-26.webm
Backwards-incompatible changes
None
AI usage